Fix templated Content-Type handling in SpringEncoder - #1406
Open
yashdotdev13 wants to merge 1 commit into
Open
yashdotdev13 wants to merge 1 commit into
yashdotdev13 wants to merge 1 commit into
Conversation
Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
kdelay
reviewed
Sep 15, 2026
kdelay
left a comment
There was a problem hiding this comment.
On 86bda63, JDK 17: core module 426 tests / 0 failures. Two gaps before this closes #116:
-
The template is dropped, not deferred: the headers get overwritten with the converter's, so
{Content-Type}plus a POJO body ends upapplication/json, and resolve(Content-Type=application/xml) still gives application/json. Re-applying the saved template after request.headers(newHeaders) makes resolve give application/xml, suite still 426/0. -
application/{ct}still throws InvalidMediaTypeException at SpringEncoder:99.
The new test asserts only body() != null, so it passes under (1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #116
SpringEncoderpreviously attempted to parse an unresolved templatedContent-Typevalue, such as{Content-Type}, usingMediaType.valueOf(...), which resulted in an invalid media type exception.This change handles unresolved
Content-Typetemplates by skipping media type parsing and removing the unresolved template before creating theHttpHeaderspassed to Spring's message converters.Changes
MediaTypeparsing for unresolvedContent-Typetemplates.Content-Typetemplates from headers passed to message converters.Content-Typeheader.Testing
SpringEncoderTests.