docs: clarify Retry series+statuses interaction and AddRequestHeader comma limitation#4201
Open
won-seoop wants to merge 1 commit into
Open
Conversation
…on in AddRequestHeader spring-cloudGH-1536: When both `series` and `statuses` are configured on the Retry filter, a retry occurs only when the response matches both. Documents how to retry on specific status codes without any series restriction. spring-cloudGH-1896: The AddRequestHeader shortcut notation parses on the first comma, so header values containing commas must use the expanded name/value form. Added a NOTE with an example for both WebFlux and WebMVC docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Please separate this into 2 different PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1536
Closes #1896
Retry filter (
series+statusesinteraction): When bothseriesandstatusesare set on the RetryGatewayFilter, a retry is only triggered when the response matches theseriesAND is listed instatuses. This was confusing to users who expectedstatusesalone to be sufficient. Added a clarifying sentence and guidance to setseriesto an empty list when retrying by specific status codes only.AddRequestHeadercomma limitation: The shortcut notationAddRequestHeader=Name, Valuesplits on the first comma, so any header value containing a literal comma is silently truncated. Added aNOTEcallout with the expandedname/valueworkaround in both the WebFlux and WebMVC docs.Test plan
series: []/series: nullYAML example is accurate for the Retry filter