Expose exact sample positions for raw model frames - #199
Open
dissonancehelix wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
model_output_frame_samples()to map unwrapped raw model frames back to their original-audio sample positions.Why
After overlapping output frames are removed,
unwrap_output()concatenates the retained blocks. Treating the global frame index asindex * FFT_HOPaccumulates timing error because the default input hop is 36,164 samples while 142 retained frames span 36,352 samples.For retained frame
jin input windoww, the exact original-audio position is:This does not alter inference arrays, note decoding, or MIDI output. It provides an opt-in alignment utility for consumers of raw
note,onset, andcontourarrays.Prepared for upstream issue #190.