This repository was archived by the owner on Feb 5, 2022. It is now read-only.
Checking if connection ended before ready#81
Open
yuvalshkolar wants to merge 3 commits intospmjs:masterfrom
Open
Checking if connection ended before ready#81yuvalshkolar wants to merge 3 commits intospmjs:masterfrom
yuvalshkolar wants to merge 3 commits intospmjs:masterfrom
Conversation
|
👍 I need this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the module against BitVise SSH Server,
In some scenarios the connection was refused but error wasn't sent,
But the connection was ready, and then just suddenly ended.
In that case, the callback under "ready" will be never called and the code is "hanged".
Now, if the connection was ended before being ready, the callback will be called.