This repository was archived by the owner on Feb 5, 2022. It is now read-only.
Emit progress event during file download + delete file on remote server#61
Open
dbaikov wants to merge 2 commits intospmjs:masterfrom
Open
Emit progress event during file download + delete file on remote server#61dbaikov wants to merge 2 commits intospmjs:masterfrom
dbaikov wants to merge 2 commits intospmjs:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
| if (err) { | ||
| return callback(err); | ||
| } | ||
| var ps = progressStream({ |
Member
There was a problem hiding this comment.
Should listen error event on ps.
Member
|
Can you rebase it? |
|
+1 |
Contributor
|
@dbaikov can you rebase it? |
VonLatvala
added a commit
to VonLatvala/node-scp2
that referenced
this pull request
Mar 1, 2018
VonLatvala
added a commit
to VonLatvala/node-scp2
that referenced
this pull request
Mar 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
This adds event to monitor file transfer progress for file download.
Change is based on https://github.com/freeall/progress-stream package
related issues #43 #57
Example:
Also this adds unlink method to delete file on remote server