HYBIM-951 rename O11y token environment variables - #199
Merged
Conversation
fercor-cisco
left a comment
Collaborator
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Clean, complete env-var rename with no stray references; two additional fixes (ADK conclude_all override, A2A test isolation) are correct and well-tested.
fercor-cisco
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the O11y SDK token environment variables to make their purpose explicit:
Why
The previous names exposed internal
SFterminology and did not clearly indicate that these tokens configure O11y Cloud authentication. Since the SDK has not been released, the old names are removed without compatibility aliases.What changed
header.
Additional fixes
A2A
splunk_ao.*attribute duplication is disabled by default while preserving nativegen_ai.*attributes.ADK
ingestion_hookcompatibility with recursive trace completion.Testing
2130 passed, 4 skipped; ADK 20 passed; live @log smoke test successfully exported to O11y.