Fix WILDCARD field name in malware_user_agents lookup - #4196
Merged
nasbench merged 2 commits intoAug 3, 2026
Conversation
The lookup declares match_type WILDCARD(malware_user_agents), but the CSV column is malware_user_agent, so Splunk applies wildcard mode to a field that does not exist and the real column falls back to exact matching. The 11 wildcard rows in the file (arkei/*, User-Agent:Mozilla/* and so on) can then only match a user agent that literally contains the asterisk, and HTTP Malware User Agent silently misses everything they cover. Point WILDCARD at the real column and bump the lookup version and modification date.
munzzyy
requested review from
P4T12ICK,
RavenTait,
ljstella,
nasbench,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
August 2, 2026 18:30
nasbench
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
malware_user_agents.ymlsetsmatch_type: WILDCARD(malware_user_agents)but the CSV column ismalware_user_agent(singular). Wildcard mode lands on a field that does not exist. The real column falls back to exact matching. 11 of the 89 rows are patterns likearkei/*andSSLoad/*. No real user agent literally contains an asterisk. HTTP Malware User Agent silently misses all of them. Exact rows still match and hide the problem.Reproduced on Splunk 9.3.14 with the app built from develop. Before:
After the one line fix and a rebuild:
The exact row
JustKiddingreturnsArbitrium-RATbefore and after. Bumped the lookup version and date since the generated transforms change.Five other lookups also name a wrong match_type field. Their match columns hold no wildcard patterns today so nothing breaks. Want those swept in this PR too or left alone? Thanks!
Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclature - N/A, no detection added or renamed