Skip to content

ci(*): update helm-chart-smoketest.yml, add wasmtime-v1 coverage#605

Merged
vdice merged 2 commits intospinframework:mainfrom
vdice:ci/update-smoketest-add-wasmtime-coverage
Mar 17, 2026
Merged

ci(*): update helm-chart-smoketest.yml, add wasmtime-v1 coverage#605
vdice merged 2 commits intospinframework:mainfrom
vdice:ci/update-smoketest-add-wasmtime-coverage

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Feb 20, 2026

Describe your changes

  • Updates the helm chart smoke test to support more than the spin shim
  • Add coverage for the wasmtime-v1 shim/app

Notes:

  • This effort has (re-)churned up issue(s) with the k3d distro (before, we would skip a few checks that glossed over the behavior); for now, in this PR, I've just included a generous timeout, but a follow-up is needed to determine why it can sometimes take many failed shim install pods before the shim is ready. (For instance, the other distros usually finish in ~1.5-3 minutes, whereas the k3d variant can be in that range but can also, mysteriously, take much longer)
  • I realize this shell-based approach is probably nearing the limits of maintainability/readability. Happy to brainstorm follow-up(s) on how to improve or migrate to a different test harness. (Could be as simple as moving inline bash into scripts to improve the workflow 'flow' itself)

Issue ticket number and link

Depends on #604 (Can rebase after that lands)

Closes #602

@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch 2 times, most recently from b01c353 to 70ced6e Compare February 21, 2026 00:17
@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch 4 times, most recently from b6d98cd to 5839a54 Compare March 10, 2026 18:08
@vdice
Copy link
Collaborator Author

vdice commented Mar 10, 2026

@kate-goldenring this should be ready for a re-review. I am still seeing instability with the k3d flavor of the smoketest (passing sometimes, timing out other times); if it continues to plague us, we can deactivate it while digging deeper. I did disable setting the containerdRuntimeOptions for this distro, but it doesn't seem to help this particular behavior. edit: #618 should fix k3d instability

Note that this PR does rely on the following fix (specifically for the wasmtime shim): #604

@vdice vdice requested a review from kate-goldenring March 10, 2026 19:22
@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch 2 times, most recently from 2d68a1e to 6c89440 Compare March 11, 2026 23:51
@vdice vdice added this to the v0.2.0 milestone Mar 16, 2026
@kate-goldenring
Copy link
Contributor

@vdice can this pr be based on the branch of #604 to scope the commits? Then once that merges, this will automatically be based on main by GitHub.

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few cleanup notes to improve maintainability.

@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch 5 times, most recently from 7c574c1 to 453b402 Compare March 16, 2026 23:32
@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch from 453b402 to 04adf37 Compare March 17, 2026 15:44
vdice added 2 commits March 17, 2026 09:44
Signed-off-by: Vaughn Dice <vdice@akamai.com>
…meoptions if k3d

Signed-off-by: Vaughn Dice <vdice@akamai.com>
@vdice vdice force-pushed the ci/update-smoketest-add-wasmtime-coverage branch from 04adf37 to 59f59c0 Compare March 17, 2026 15:44
@vdice vdice merged commit 7e6b1b8 into spinframework:main Mar 17, 2026
14 checks passed
@vdice vdice deleted the ci/update-smoketest-add-wasmtime-coverage branch March 17, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: add coverage for wasmtime

2 participants