Repository navigation
refgen: the table of states is the API's, each row its value's comment in spin's proto - #56
Merged
Merged
Conversation
…t in spin's proto checkStates held the hand-written table to WorkspaceState's names; now that spin's OpenAPI document carries each value's comment (x-enum-descriptions), the table is written from it, and what a state means is said once, where it is defined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table of states in
concepts/workspaces.mdis written byrefgenfrom the API'sWorkspaceState. Each row is that value's comment in spin'scommon.proto, which the OpenAPI document carries asx-enum-descriptions(spin #656 turned that on, #658 rewrote the comments for this page's reader; both are in v20261025.01).checkStates, which only held the table's names to the API's.## States, failsrefgenrather than keeping the old table.FAILEDrow says.task reference:checkpasses against v20261025.01;go test ./...intools/passes.🤖 Generated with Claude Code