fix(install): explain shell PATH activation - #3903
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe installer now provides conditional completion guidance. It gives shell profile reload instructions when a valid profile exists. Otherwise, it gives PATH setup instructions. ChangesInstallation guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @rxri — CodeRabbit suggested you as the reviewer for this small installer UX fix. When you have a chance, would you mind taking a look? Thanks! |
Summary
spicetifyZDOTDIRlocationsWhy
The shell installer updates a startup file, but when invoked through
curl | shit cannot update the already-running parent shell. The existing completion message immediately suggests runningspicetify --help, which results incommand not founduntil the user opens a new terminal or reloads the profile.Windows is unaffected:
install.ps1updates$env:PATHin the current PowerShell process as well as the persistent user PATH.Verification
sh -n install.shZDOTDIR, bash, and fishspicetifySummary by CodeRabbit
PATHsetup instructions when no usable shell profile is available.