Chore: add Telegram repo safe workflow#13
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69bab85a9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if isinstance(exc, FastReadToolError): | ||
| error["endpoint"] = exc.endpoint | ||
| error["tool_error_code"] = tool_error_code(exc.payload) | ||
| error["tool_error_payload"] = exc.payload |
There was a problem hiding this comment.
In the CLI path this branch never sees tool failures from telegram_read: read_once raises FastReadToolError, but read_with_failover catches it as the base FastReadError and re-raises a generic FastReadError after the loop. For structured MCP errors such as {"code":"permission_denied"}, the final string does not satisfy exception_is_tool_error, so telegram-fast-read-today emits a raw error instead of the new tool_error_code/payload fields.
Useful? React with 👍 / 👎.
|
|
||
| ( | ||
| cd "${ROOT}/mcp" | ||
| "${MCP_PYTHON}" -m unittest discover -s tests |
There was a problem hiding this comment.
This gate is advertised as running the MCP tests, but unittest discover skips the repo's pytest-style module-level tests, such as mcp/tests/test_metadata_reads.py and mcp/tests/test_metadata_scaffold.py. A regression in those files can pass scripts/safe-gate locally while still failing the release/CI pytest run, so the pre-commit gate is not checking the same MCP suite it claims to cover.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
GitHub context