Lazy load model versions and enforce strict typing#36
Open
bact wants to merge 8 commits into
Open
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
benjarobin
suggested changes
Jun 5, 2026
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Revise per code review Co-Authored-By: Benjamin Robin <benjarobin@users.noreply.github.com> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-Authored-By: Benjamin Robin <benjarobin@users.noreply.github.com> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
I just added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements PR #31 (strict typing) and incorporates the suggestion to avoid loading all versions of the SPDX model upon import spdx_python_module. This saves memory and reduces load time (see #31 (comment)).
from spdx_python_model import *now no longer load modelsExisting code like this (from README) will still work:
This code will still work too:
The only breaking change is this code:
The above code (no. 3) will no longer work because models (
v3_0_1etc) are no longer part of__all__.