Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some changes from a few months back that I made, which you may be interested in.
Essentially, the data stored in nodes before the patch are bitvectors where the most significant set bit implies that all of the less significant bits are also set. Thus, we can simply store the position of the most significant bit as a 1,2,4, or 8 bit integer depending on the depth. This not only saves some space, but also makes some operations feasible in less instructions.
If I remember correctly, the speedup is right around 10%.
Currently, the PR is a little rough around the edges, but if you like the changes here, I'll clean up the comments and document how I generated the LUTs.