Skip to content

Wait for WebAssembly setup before writing SPZ #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oscarlorentzon wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Wait for WebAssembly setup before writing SPZ #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/splat-painter/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@

// Now export the PackedSplats to SPZ
console.log("Writing splats to SPZ...");
const { fileBytes: spzBytes } = writeSpz(newPackedSplats, ioOptions.maxSh, ioOptions.fractionalBits);
const { fileBytes: spzBytes } = await writeSpz(newPackedSplats, ioOptions.maxSh, ioOptions.fractionalBits);

console.log("Creating download...");
const blob = new Blob([spzBytes], { type: "application/octet-stream" });
Expand Down
8 changes: 5 additions & 3 deletions src/spz.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,18 @@ export function writeSpz(
splats: PackedSplats | ExtSplats,
maxSh?: number,
fractionalBits?: number,
): { fileBytes: Uint8Array };
): Promise<{ fileBytes: Uint8Array }>;
export function writeSpz(
splats: PackedSplats | ExtSplats,
options?: WriteSpzOptions,
): { fileBytes: Uint8Array };
export function writeSpz(
): Promise<{ fileBytes: Uint8Array }>;
export async function writeSpz(
splats: PackedSplats | ExtSplats,
maxShOrOptions?: number | WriteSpzOptions,
fractionalBits?: number,
) {
await wasm.initialization;

const options: WriteSpzOptions =
typeof maxShOrOptions === "number"
? { maxSh: maxShOrOptions, fractionalBits }
Expand Down
Loading