add -Werror unit tests#15
Open
haampie wants to merge 2 commits into
Open
Conversation
Collaborator
kwryankrattiger
left a comment
kwryankrattiger
left a comment
There was a problem hiding this comment.
A couple small issues
|
|
||
| _werror_set_mode all | ||
| _out=$(dump_args cc "$_in2") | ||
| expect_contains werror_all2 "$_out" '-Werror' |
Collaborator
There was a problem hiding this comment.
Suggested change
| expect_contains werror_all2 "$_out" '-Werror' | |
| expect_contains werror_all2 "$_out" '-Werror' | |
| expect_not_contains werror_all2 "$_out" '-Werror-implicit-function-declaration' |
Collaborator
There was a problem hiding this comment.
Ah, I missed the star for the all matching. In that case, we should ensure they are both still there.
Suggested change
| expect_contains werror_all2 "$_out" '-Werror' | |
| expect_contains werror_all2 "$_out" '-Werror' | |
| expect_contains werror_all2 "$_out" '-Werror-implicit-function-declaration' |
| ;; | ||
| specific) | ||
| SPACK_COMPILER_FLAGS_KEEP='-Werror-*|-Werror=*' | ||
| SPACK_COMPILER_FLAGS_REPLACE='-Werror-|-Wno-error= -Werror|-Wno-error' |
Collaborator
There was a problem hiding this comment.
Suggested change
| SPACK_COMPILER_FLAGS_REPLACE='-Werror-|-Wno-error= -Werror|-Wno-error' | |
| SPACK_COMPILER_FLAGS_REPLACE='-Werror|-Wno-error' |
Member
Author
There was a problem hiding this comment.
This isn't right, -Werror-x should be replaced with -Wno-error=x.
Collaborator
There was a problem hiding this comment.
In this context it looks like it conflicts with the SPACK_COMPILER_FLAGS_KEEP. You say keep specific errors, and also replace specific errors -Wno- prefix.
Collaborator
There was a problem hiding this comment.
Hm, maybe this is a good test for that reason. Maybe also worth documenting that behavior somewhere other than the code.
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
hs/fix/tests-flags
branch
from
5db899a to
5b0d8bb
Compare
Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>
haampie
force-pushed
the
hs/fix/tests-flags
branch
from
5951989 to
a91759e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.