Skip to content

Upgrade Core and Blaze#919

Merged
jviotti merged 1 commit into
mainfrom
upgrades-all
Jun 11, 2026
Merged

Upgrade Core and Blaze#919
jviotti merged 1 commit into
mainfrom
upgrades-all

Conversation

@jviotti

@jviotti jviotti commented Jun 11, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 122 files

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

Re-trigger cubic

@augmentcode

augmentcode Bot commented Jun 11, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR bumps the vendored core and blaze dependencies to newer upstream revisions, bringing in updated schema tooling and a substantial gzip/crypto refresh.

Changes:

  • Updated top-level DEPENDENCIES pins for core and blaze.
  • blaze: introduced BundleMode to control whether meta-schemas are bundled, and propagated the new parameter through bundling call sites.
  • blaze: improved reference framing by canonicalizing pointer fragments and adjusting URI resolution inputs.
  • core: removed vendored zlib and related CMake discovery logic.
  • core: expanded gzip support around libdeflate usage and added a native Deflate/Huffman decoding implementation.
  • core: enhanced crypto utilities (CRC32 improvements + new SHA1/FNV-128 support) and updated build wiring for the crypto component.
  • core: updated SIMD configuration for AArch64/Apple Silicon CRC enabling behavior.

Technical Notes: The update replaces the previous zlib vendoring approach with internal deflate primitives and adds new hashing primitives, so platform coverage (endianness/ISA features) is an important consideration.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

while (remaining >= 8) {
std::uint64_t chunk{0};
std::memcpy(&chunk, data, sizeof(chunk));
checksum = __crc32d(checksum, chunk);

@augmentcode augmentcode Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In vendor/core/src/core/crypto/crypto_crc32.cc:71, the ARM CRC32 fast-path feeds __crc32d with a std::uint64_t populated via memcpy, which can process bytes in the wrong order on big-endian AArch64 and yield different CRCs. Consider ensuring this path only activates when the target endianness matches the expected byte order (or otherwise guaranteeing a consistent byte order).

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit ac8e1af into main Jun 11, 2026
13 of 14 checks passed
@jviotti jviotti deleted the upgrades-all branch June 11, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant