Upgrade Core and Blaze#919
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
No issues found across 122 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
🤖 Augment PR SummarySummary: This PR bumps the vendored Changes:
Technical Notes: The update replaces the previous zlib vendoring approach with internal deflate primitives and adds new hashing primitives, so platform coverage (endianness/ISA features) is an important consideration. 🤖 Was this summary useful? React with 👍 or 👎 |
| while (remaining >= 8) { | ||
| std::uint64_t chunk{0}; | ||
| std::memcpy(&chunk, data, sizeof(chunk)); | ||
| checksum = __crc32d(checksum, chunk); |
There was a problem hiding this comment.
In vendor/core/src/core/crypto/crypto_crc32.cc:71, the ARM CRC32 fast-path feeds __crc32d with a std::uint64_t populated via memcpy, which can process bytes in the wrong order on big-endian AArch64 and yield different CRCs. Consider ensuring this path only activates when the target endianness matches the expected byte order (or otherwise guaranteeing a consistent byte order).
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com