Skip to content

Don't set default options on header-only libraries #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Sep 5, 2026
Merged

Don't set default options on header-only libraries #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmake/common/targets/library.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ function(sourcemeta_library)
else()
add_library(${TARGET_NAME} INTERFACE
${PUBLIC_HEADER} ${ABSOLUTE_PRIVATE_HEADERS})
sourcemeta_add_default_options(INTERFACE ${TARGET_NAME})
endif()

add_library(${ALIAS_NAME} ALIAS ${TARGET_NAME})
Expand Down
3 changes: 2 additions & 1 deletion test/test/clitest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ endif()
# framework itself is: through its command line, against a golden diagnostic.
# Each case runs from the fixture directory so that the path a diagnostic names
# is the bare script name rather than wherever the checkout happens to live
add_executable(sourcemeta_core_clitest_stub stub.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME clitest
VARIANT stub SOURCES stub.cc)
target_link_libraries(sourcemeta_core_clitest_stub
PRIVATE sourcemeta::core::options)
target_link_libraries(sourcemeta_core_clitest_stub
Expand Down
24 changes: 16 additions & 8 deletions test/test/framework/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,40 @@
add_executable(sourcemeta_core_test_success test_success.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT success SOURCES test_success.cc)
target_link_libraries(sourcemeta_core_test_success
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_failure test_failure.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT failure SOURCES test_failure.cc)
target_link_libraries(sourcemeta_core_test_failure
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_diff test_diff.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT diff SOURCES test_diff.cc)
target_link_libraries(sourcemeta_core_test_diff
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_throw test_throw.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT throw SOURCES test_throw.cc)
target_link_libraries(sourcemeta_core_test_throw
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_filter test_filter.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT filter SOURCES test_filter.cc)
target_link_libraries(sourcemeta_core_test_filter
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_fixture test_fixture.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT fixture SOURCES test_fixture.cc)
target_link_libraries(sourcemeta_core_test_fixture
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_dynamic test_dynamic.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT dynamic SOURCES test_dynamic.cc)
target_link_libraries(sourcemeta_core_test_dynamic
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

add_executable(sourcemeta_core_test_empty test_empty.cc)
sourcemeta_executable(NAMESPACE sourcemeta PROJECT core NAME test
VARIANT empty SOURCES test_empty.cc)
target_link_libraries(sourcemeta_core_test_empty
PRIVATE sourcemeta::core::test sourcemeta::core::test_main)

Expand Down
Loading