dev/viewership-metrics: Probe every redirect rule on the live site - #1939
Draft
marcleblanc2 wants to merge 7 commits into
Draft
dev/viewership-metrics: Probe every redirect rule on the live site#1939marcleblanc2 wants to merge 7 commits into
marcleblanc2 wants to merge 7 commits into
Conversation
…ents and Cloudflare traffic probe-redirects.mjs requests each rule's source, follows the chain like a browser, records every hop, the final status, whether the first redirect matches the rule, and whether the fragment the user ends up with exists on the page. Joins page-views-by-path.md rows for source, destination and final page. Summary groups live rules by source/destination fragment case. Rule loading moves to redirect-rules.mjs, shared with page-views-report. Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d Co-authored-by: Amp <amp@ampcode.com>
…404s; probe summary adds traffic by status and rule alignment Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d Co-authored-by: Amp <amp@ampcode.com>
…ce-fragment rule never counts as firing
…atch fires), add sitemap source/destination, resolve destination constants Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d
…ing duplicates zero it Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d
…itemap source/destination columns Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d
…e other keys Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08968-179e-7528-9162-44dd0fbb964d
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1890.
npm run probe-redirectsrequests every rule insrc/data/redirects.tson sourcegraph.com, follows the redirects like a browser, and writesviewership-metrics/reports/redirect-probe.json: per rule, every hop, final URL/status, whether the first redirect is the one the rule promises, whether the#fragmentthe user ends up with exists on the page, and the Cloudflare rows for source, destination and final page.Headline numbers from the first run (962 live rules):
/graphbook*→sourcegraph.com/handbookredirects to itself;/@v5.3.0/admin/observability/*ping-pongs withdocs.sourcegraph.com)#fragmentin the source. Browsers never send fragments, so none of them can match as written; 200 fall through to a bare-path rule, 30 to the page itself#fragmentin the destination; the anchor exists on the final page for 9See
viewership-metrics/README.md→ Redirect probe for the field meanings.Replaces #1897 (branch renamed to
marc/redirect-probe).