test: PR checks on a broken PR, then remediated (do not merge) - #1914
Closed
marcleblanc2 wants to merge 11 commits into
Closed
test: PR checks on a broken PR, then remediated (do not merge)#1914marcleblanc2 wants to merge 11 commits into
marcleblanc2 wants to merge 11 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ The redirects an earlier revision of this PR broke are fixed |
This comment has been minimized.
This comment has been minimized.
Contributor
✅ The broken links an earlier revision of this PR introduced are fixed |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Direct preview links to pages changed in this PR: |
dev/check-redirects.mjs checks every entry in src/data/redirects.ts: source shadows a page, source has a #fragment, duplicate source, /docs prefix, chained redirect, missing destination page or heading. The workflow compares against the merge base, so only redirects a PR breaks are reported, grouped by problem with the fix explained under each heading, and posts one suggested change per fixable entry the PR added (deleted again once the finding is gone). Not part of `npm run check`: main has hundreds of pre-existing findings. Squash of the check-redirects branch rebased onto main; the check-links commits it carried are already on main. Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
test-pr-checks-remediated
branch
from
September 11, 2026 11:22
623c137 to
871eecb
Compare
…ady names Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
test-pr-checks-remediated
branch
from
September 11, 2026 11:27
871eecb to
9010c10
Compare
… fact per line - Review comments: one suggested change per finding with a fix, no review body. Each starts with a marker so the workflow can delete suggestions for findings that are fixed and skip ones already posted. - Summary comment and review comments list line, link, problem, and fix on their own lines. - Absolute links to this site get their own section instead of Outbound. - Case-mismatch findings now carry a fix. - Wording: 'links on this site', 'these other pages', drop docs.sourcegraph.com; reproduce command matches package.json. Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
…roblem Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
…orted dictionary entries - Summary comment: line and column link to the file in source view (?plain=1) with the word highlighted; each item is `word` → `first suggestion` instead of the whole line. - check-spelling.mjs reports entries added to cspell-allow-list.txt or cspell-block-list.txt out of alphabetical order (case- and accent-insensitive, like CSpell matches; comments and blank lines start a new run). Trailing '# comments' after a word are ignored, as CSpell does. - Drop the unused context field from the JSON findings. Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
…ted entry belongs on Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
… (do not merge) Check links: three absolute self-links (one to a moved page) and a dead external link on one line; a missing page, missing heading, and wrong-case path on the next; and the "Symbol search" heading renamed to break the inbound anchor link from search-based-code-navigation.mdx. Spell check: nine misspellings on one line, five of them block-list words. Check redirects: one broken entry per category (shadowed page, #fragment source, /docs prefix, duplicate source, chain, missing page, missing heading). Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9
Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
Restore the deleted page, the shadowed redirect page, and both renamed headings; point the dead links at real targets; fix the one misspelling CSpell guessed wrong (across, not arcos); drop the unsorted allow-list entry. Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
test-pr-checks-remediated
branch
from
September 11, 2026 11:32
9010c10 to
70f34aa
Compare
Contributor
Author
|
Replaced by , rebuilt on current main and the latest check code. |
Contributor
Author
|
Replaced by #1921, rebuilt on current main and the latest check code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same commit as #1913, which stays broken for comparison. Here, a second commit applies the fixes the checks suggested (check-links and spell check review suggestions), and a third fixes what the checks could only report: the dead external link, missing page/heading/wrong-case links, the inbound anchor link, the spelling suggestion CSpell got wrong, and the broken redirects.
The redirect check is not on
mainyet; the first commit copies.github/workflows/check-redirects.ymlanddev/check-redirects.mjsfrom #1880 so it runs here.Do not merge.