Remove docs build lint and Browserslist warnings - #1909
Closed
marcleblanc2 wants to merge 4 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a08e2d-682f-75dd-a050-cb9bf8888dac Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
build/lint-warnings-and-caniuse
branch
from
September 11, 2026 10:20
fbb32fc to
4501910
Compare
marcleblanc2
marked this pull request as ready for review
September 11, 2026 10:20
Wrap prose at 80 columns, run Prettier (single-space list markers, aligned table), add a language to the MDX example fence and alt text to both images, and shorten the two lines that could not wrap. Amp-Thread-ID: https://ampcode.com/threads/T-01a08e2d-682f-75dd-a050-cb9bf8888dac Co-authored-by: Amp <amp@ampcode.com>
Wrap the build commands at 80 columns and move the link-check guidance into its own flat list so Prettier and markdownlint agree on indentation. The AI Chat Integration and Important Notes sections described a runLLM widget removed in #1536; replace them with a two-line note. Amp-Thread-ID: https://ampcode.com/threads/T-01a08e2d-682f-75dd-a050-cb9bf8888dac Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08e2d-682f-75dd-a050-cb9bf8888dac Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
|
Moved to #1943 (branch renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 6b of the Vercel audit tracked in #1905. Rebased on current
main.What was warning
pnpm buildprinted one Browserslist warning and six ESLint warnings on every deploy.caniuse-liteandbaseline-browser-mappingentries inpnpm-lock.yaml. Lockfile only.@next/next/no-img-elementinLogo.tsx,LinkCards.tsx,ProductCards.tsx,ZoomableImage.tsx,api/og/[...path]/route.tsx— kept the native<img>with a one-line disable and reason at each site.next/imagewould route every image through Vercel Image Optimization (billed), needs known dimensions that arbitrary MDX images don't have, and Satori (OG images) cannot rendernext/imageat all.react-hooks/exhaustive-depsinContentTabs.jsx— moved the URL-to-tab selection into the effect and listed its inputs. Note: Stop bundling the docs corpus into the client JS (24 MB chunk) #1915 deletes this file outright (it's unused); whichever PR merges second needs a trivial rebase that keeps the deletion.README markdownlint findings (second commit)
markdownlint-cli2 README.mdreported 49 findings: 27 long lines, 12 list markers padded to-(stale Prettier 2 output; Prettier 3 in this repo writes-), table pipes without spaces, an MDX example fence with no language, and two images with no alt text. Prose is wrapped at 80 columns, the file is run throughpnpm format's Prettier config, and two lines that cannot wrap (a table cell, a long link inside a code block) are shortened. Wording is otherwise unchanged apart from one "relevant relevant" typo.AGENTS.md (third commit)
Same wrapping and Prettier treatment. Two content changes to flag: the nested link-check bullets are now a flat
### Linkslist (Prettier indents nested lists by 4, markdownlint wants 2) with the long external-check command in ashfence; and the AI Chat Integration / Important Notes sections are deleted, because they described a runLLM widget that #1536 removed (rg -i runllm src/finds nothing).Verification
pnpm install --frozen-lockfile,pnpm lint→✔ No ESLint warnings or errorspnpm build→ no Browserslist warning;npx tsc --noEmitcleannpx markdownlint-cli2 README.md AGENTS.md→ 0 issues;prettier --check README.md AGENTS.md→ cleanHow to review
Read the seven
eslint-disablecomments and check the reason on each makes sense; the lockfile diff is two version bumps. For the README,git diff --word-diffshows only the wrapping and the small edits listed above.