Remove duplicated docs build check executions - #1908
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marcleblanc2
marked this pull request as ready for review
September 11, 2026 07:47
marcleblanc2
changed the title
burmudar
reviewed
Sep 11, 2026
| "scripts": { | ||
| "dev": "next dev", | ||
| "build": "next build", | ||
| "build": "node dev/check-links.mjs && node dev/check-filenames.mjs && node dev/check-images.mjs && node dev/generate-mermaid-icons.mjs && next build", |
Contributor
There was a problem hiding this comment.
there must be an aggregate way to have all of these defined in one checks.mjs file?
node dev/checks.mjs - default everything
node dev/checks.mjs links
node dev/checks.mjs filenames
Contributor
Author
There was a problem hiding this comment.
Good thinking. I've had Amp write one script which calls the other 3.
Amp-Thread-ID: https://ampcode.com/threads/T-01a08e2d-682f-75dd-a050-cb9bf8888dac Co-authored-by: Amp <amp@ampcode.com>
Review feedback on #1908: one dispatcher instead of four commands in the build script. `node dev/checks.mjs` runs every check, a name picks one (`links`, `filenames`, `images`), and flags pass through to a single check. The three check-* npm scripts collapse into `npm run check`. Amp-Thread-ID: https://ampcode.com/threads/T-01a08f98-1ebd-76aa-8801-45886f61a68c Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
build/run-checks-once
branch
from
September 11, 2026 08:34
2404edb to
b3621ac
Compare
burmudar
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is task 6a of the Vercel audit tracked in #1905.
Problem
next buildevaluated the asynchronous Next.js config twice before printing the Next.js bannerLogs recorded
phase-production-buildtwice in process 31244, and both evaluations ran all four checks eachChanges
Run the four checks in order from the
buildpackage script, beforenext build. Vercel invokes this script once, while Next.js may evaluate its config more than once.Chain commands with
&&, so any failed check exits non-zero and prevents the deploy build from continuingKeep the existing
generate-mermaid-logosscript name for compatibility and point it at the realdev/generate-mermaid-icons.mjsfileUpdate the build-command guidance to distinguish
npm run buildfrom directnext buildTest plan
Note: #1907 also edits
next.config.js; whichever merges second needs a trivial rebase.