localization: complete German translations - #2600
Conversation
| <x:String x:Key="Text.CommitCM.CopyAuthorTime" xml:space="preserve">Autor-Zeitpunkt</x:String> | ||
| <x:String x:Key="Text.CommitCM.CopyCommitMessage" xml:space="preserve">Commit-Nachricht</x:String> | ||
| <x:String x:Key="Text.CommitCM.CopyCommitter" xml:space="preserve">Committer</x:String> | ||
| <x:String x:Key="Text.CommitCM.CopyCommitterTime" xml:space="preserve">Committer-Zeitpunkt</x:String> |
There was a problem hiding this comment.
Wrong. That should be "Commit-Zeitpunkt" because we are in the context menu of the history where the table head says "Commit Time" -> "Commit-Zeitpunkt" and we are talking about the same timestamp. Refering to the Committer makes no sence there.
Therefore the English base translation is wrong.
There was a problem hiding this comment.
I'm not sure about this.
I would agree with you that it makes no sense to reference the committer time, since there's only the time when a commit was created.
What solution would you propose?
Should we change all translations, including the variable name, to Text.CommitCM.CopyCommitTime?
Or should we simply keep Committer-Zeitpunkt as the translation, since all the other languages also refer to it that way?
There was a problem hiding this comment.
This translation is based on Git's own definition and can be understood as setting the author date (Author Date) and the committer date (Committer Date). Reference: https://git-scm.com/docs/git-commit#_commit_information
There was a problem hiding this comment.
So, if I understand correctly, @gadfly3173, you would keep the current translation?
There was a problem hiding this comment.
My view is that “Committer Date/Time” is the correct translation, and this is consistent with the Git documentation. However, I am not a maintainer, so the final decision rests with the maintainer @love-linger .
There was a problem hiding this comment.
@gadfly3173 got a good point there! Committer-Time is technically correct and Commit-Time would be more UX friendly.
Happy with either solution and @love-linger can decide, agreed!
3 participants
Completed de_DE from 89.52% to 100% (107 keys).