fix: sometimes no staged/unstaged changes were shown #2030
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a race condition it was possible, that there were changes (the badge for LOCAL CHANGES showed a non-zero number), but there were no staged or unstaged files shown. The problem was, that while loading the changes for the first time, the watcher could start the loading a second time. The first loading was cancelled, but it could have already set the first instance variable. Therefore, on the second load a shortcut was done, since there was seemingly no change.
love-linger
added a commit
that referenced
this pull request
Jan 5, 2026
The latest change collection should be passed to `GetStagedChange` Signed-off-by: leo <longshuang@msn.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a race condition it was possible, that there were changes (the badge for LOCAL CHANGES showed a non-zero number), but there were no staged or unstaged files shown.
The problem was, that while loading the changes for the first time, the watcher could start the loading a second time. The first loading was cancelled, but it could have already set the first instance variable. Therefore, on the second load a shortcut was done, since there was seemingly no change.