AMD SFH HID - Do not log a separate error message for EOPNOTSUPP when device discovery fails #532
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AMD Sensor Fusion Hub device driver generates an error during init on boot for devices that don't support it: 'amd_sfh_hid_client_init failed err -95' Code 95 is EOPNOTSUPP, i.e. operation not supported. That code within this context should not be logged as an error message (there is already a warning message), which is the change being made here. This bug was already fixed in the kernel years ago shortly after it was was introduced. However, the fix eventually got washed out (presumably unintentionally). Here is when the fix was originally implemented in the kernel: torvalds/linux@e51d8d3 Signed-off-by: Christopher Croy <ccroy@arista.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMD Sensor Fusion Hub device driver generates an error during init on boot for devices that don't support it (i.e. when device discovery fails):
amd_sfh_hid_client_init failed err -95There is already a warning message for this when device discovery fails, so do not log a separate error message.
This bug was fixed in the kernel in 2022 shortly after it was originally introduced: torvalds/linux@e51d8d3
However, the fix eventually got washed out here: torvalds/linux@2105e8e