Ensure skip-ci label workable and simplify profiling job conditions by rockleona · Pull Request #877 · solvcon/modmesh

rockleona · 2026-06-09T12:08:13Z

Simplify profiling job conditions and ensure the skip-ci label is honored for push-triggered updates so CI runs are not noisy or duplicated.

This PR removes push/pull_request triggers from the profiling workflow and updates check_skip_ci to detect and respect skip-ci on push-triggered runs so profiling jobs run only when intended.

Related to #858.

rockleona · 2026-06-09T12:12:14Z

+            async function checkPrNumber(prNumber) {
+              const { data: pr } = await github.rest.pulls.get({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                pull_number: prNumber,
+              });
+
+              if (pr.labels && pr.labels.some(label => label.name === 'skip-ci')) {
+                core.notice(`CI skipped: the "skip-ci" label is present on PR #${pr.number}.`);
+                return true;
+              }
+
+              if (trusted.includes(pr.author_association) && hasControlLine(pr.body)) {
+                core.notice(`CI skipped: control string in the description of PR #${pr.number}.`);
+                return true;
+              }
+
+              const comments = await github.paginate(
+                github.rest.issues.listComments,
+                {
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  issue_number: pr.number,
+                  per_page: 100,
+                });
+              const hit = comments.find(
+                comment => trusted.includes(comment.author_association) && hasControlLine(comment.body));
+              if (hit) {
+                core.notice(`CI skipped: control string in a comment on PR #${pr.number}.`);
+                return true;
+              }
+
+              return false;


This helper function will check the content in specific PR, and return boolean of true if it needs to skip.

rockleona · 2026-06-09T12:15:07Z

+            if (github.event_name === 'pull_request') {
+              const pr = context.payload.pull_request;
+              if (!pr) {
+                core.setOutput('skip', 'false');
+                return;
+              }
+              const shouldSkip = await checkPrNumber(pr.number);
+              core.setOutput('skip', shouldSkip ? 'true' : 'false');
              return;
            }

-            // 3. The control string in a comment from a member.
-            const comments = await github.paginate(
-              github.rest.issues.listComments,
-              {
+            else if (github.event_name === 'push') {
+              const sha = context.sha || context.payload.after;
+              if (!sha) {
+                core.setOutput('skip', 'false');
+                return;
+              }
+
+              const assoc = await github.rest.repos.listPullRequestsAssociatedWithCommit({
                owner: context.repo.owner,
                repo: context.repo.repo,
-                issue_number: pr.number,
-                per_page: 100,
+                commit_sha: sha,
              });
-            const hit = comments.find(
-              comment => trusted.includes(comment.author_association) &&
-                         hasControlLine(comment.body));
-            if (hit) {
-              core.notice('CI skipped: control string in a comment.');
-              core.setOutput('skip', 'true');
+
+              const prs = assoc.data || [];
+              for (const p of prs) {
+                const num = p.number;
+                if (await checkPrNumber(num)) {
+                  core.setOutput('skip', 'true');
+                  return;
+                }
+              }
+
+              core.setOutput('skip', 'false');
              return;
            }


check_skip_ci will call by other action (workflow), it will check what triggered the action and check if the push commit is related to any PR, then call the helper function checkPrNumber.

rockleona · 2026-06-09T12:15:30Z

-  push:
-  pull_request:


Removed these 2 triggers

rockleona · 2026-06-09T12:16:06Z


    # Run profiling only on schedule or when MMGH_FORCE_PROFILE is set to 'enable'
    # You can refer to https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables to set MMGH_FORCE_PROFILE in the fork repository settings for testing purposes.
-    if: ${{ (github.event_name == 'schedule' && vars.MMGH_NIGHTLY == 'enable') || vars.MMGH_FORCE_PROFILE == 'enable' }}


So no need to check event_name since the trigger is clean.

If removing push and pull_request from on, MMGH_FORCE_PROFILE will not work when on is not schedule. We need to allow to use MMGH_FORCE_PROFILE to force profiling on push and pull_request.

yungyuc

Need to allow to use MMGH_FORCE_PROFILE to force profiling on push and pull_request.
Reduce patch complexity if possible.

yungyuc · 2026-06-09T13:50:55Z


    # Run profiling only on schedule or when MMGH_FORCE_PROFILE is set to 'enable'
    # You can refer to https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables to set MMGH_FORCE_PROFILE in the fork repository settings for testing purposes.
-    if: ${{ (github.event_name == 'schedule' && vars.MMGH_NIGHTLY == 'enable') || vars.MMGH_FORCE_PROFILE == 'enable' }}


If removing push and pull_request from on, MMGH_FORCE_PROFILE will not work when on is not schedule. We need to allow to use MMGH_FORCE_PROFILE to force profiling on push and pull_request.

yungyuc · 2026-06-09T13:52:58Z

-              core.notice('CI skipped: the "skip-ci" label is present.');
-              core.setOutput('skip', 'true');
-              return;
+            async function checkPrNumber(prNumber) {


The patch looks overly complex. I am not sure why a simple conditional check need to use async. If it is necessary, explain in PR annotation. If it is not, use minimal diff for the fix.

yungyuc · 2026-06-09T13:54:23Z

@ExplorerRay @chestercheng please help take a look.

chestercheng · 2026-06-10T23:11:10Z

The requirement in #858 seems to be:

If the PR has the skip-ci label, a later push should not run CI.
If the PR does not have the skip-ci label, a later push should run CI.

So, I wonder if we can simplify this design.

Maybe we can make the skip-ci label the single source of truth,
so that check_skip_ci.yml only manages the label and all other workflows
only check the label.

Then labels become the only CI gate:

skip-ci controls whether CI should be skipped.
profiling controls whether the profiling workflow should run.
Removing skip-ci allows CI to run again.

This may make the behavior easier to understand and maintain.

yungyuc · 2026-06-11T00:20:49Z

The requirement in #858 seems to be:

If the PR has the skip-ci label, a later push should not run CI.

If the PR does not have the skip-ci label, a later push should run CI.

Issue #858 is just about the skip-ci label, but the full picture includes the [skip-ci] control line in PR comments: #814 (comment) . See also PR #820 .

Maybe we can make the skip-ci label the single source of truth, so that check_skip_ci.yml only manages the label and all other workflows only check the label.

It sounds like a good simplification for check_skip_ci.yml to be a single source of truth.

rockleona added 3 commits June 9, 2026 00:03

ci: support push-triggered runs in check_skip_ci

6de91a6

ci: remove push and pull_request fire in profiling

270b7c1

ci: simplify condition for profiling job execution

6664c81

rockleona commented Jun 9, 2026

View reviewed changes

yungyuc requested changes Jun 9, 2026

View reviewed changes

yungyuc assigned rockleona Jun 9, 2026

yungyuc added the build Build system and automation label Jun 9, 2026

yungyuc linked an issue Jun 9, 2026 that may be closed by this pull request

SimpleArray should handle negative NumPy strides and Python slice semantics consistently #856

Open

7 tasks

yungyuc removed a link to an issue Jun 9, 2026

SimpleArray should handle negative NumPy strides and Python slice semantics consistently #856

Open

7 tasks

yungyuc added this to speed up Github Actions CI Jun 9, 2026

github-project-automation Bot moved this to Todo in speed up Github Actions CI Jun 9, 2026

yungyuc moved this from Todo to In Progress in speed up Github Actions CI Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure skip-ci label workable and simplify profiling job conditions#877

Ensure skip-ci label workable and simplify profiling job conditions#877
rockleona wants to merge 3 commits into
solvcon:masterfrom
rockleona:issue-858

rockleona commented Jun 9, 2026

Uh oh!

rockleona Jun 9, 2026

Uh oh!

rockleona Jun 9, 2026

Uh oh!

rockleona Jun 9, 2026

Uh oh!

rockleona Jun 9, 2026

Uh oh!

yungyuc Jun 9, 2026

Uh oh!

yungyuc left a comment

Uh oh!

yungyuc Jun 9, 2026

Uh oh!

yungyuc Jun 9, 2026

Uh oh!

yungyuc commented Jun 9, 2026

Uh oh!

chestercheng commented Jun 10, 2026

Uh oh!

yungyuc commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rockleona commented Jun 9, 2026

Uh oh!

rockleona Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

rockleona Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

rockleona Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

rockleona Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

yungyuc Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

yungyuc Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

yungyuc Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

yungyuc commented Jun 9, 2026

Uh oh!

chestercheng commented Jun 10, 2026

Uh oh!

yungyuc commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants