Place ESP8266 timer ISR paths in IRAM - #26
Open
realholgi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ClickEncoder::service()is intended for timer-ISR use, but on ESP8266 it and the helper reached from its button path are linked into flash. When the ESP8266 flash cache is temporarily disabled, an active timer1 ISR can fault while executing that code.Change
Add an ESP8266-only
IRAM_ATTRmacro and apply it toClickEncoder::service()andClickEncoder::getPinState(). Other platforms retain their existing placement.Verification
Built and exercised the change on ESP8266 hardware. Ten consecutive History-page navigation cycles—which previously reliably triggered
Illegal instructioninClickEncoder::service()fromtimer1_isr_handler—completed without a reset.