[solidus_admin] Add stores editor by benjaminwil · Pull Request #6589 · solidusio/solidus

benjaminwil · 2026-09-08T19:22:20Z

Summary

Replaces #6228.

This pull request creates the initial store creator and editor interface for solidus_admin. I have co-opted an old pull request implementing this feature and have verified, after rebasing against main and resolving merge conflicts, that it's in working order.

Since I am creating this replacement PR, I will take responsibility for resolving any issues that come up as the result of code review.

Checklist

The original author checked off all checklist items on the original pull request #6228.

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

I agree that my PR will be published under the same license as Solidus.
I have written a thorough PR description.
I have kept my commits small and atomic.
I have localized any and all user-facing strings that I added to the source code.
I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov · 2026-09-08T19:27:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (6692e51) to head (f7c77a8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6589      +/-   ##
==========================================
+ Coverage   92.26%   92.29%   +0.02%     
==========================================
  Files        1037     1040       +3     
  Lines       21241    21274      +33     
==========================================
+ Hits        19598    19634      +36     
+ Misses       1643     1640       -3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benjaminwil · 2026-09-08T19:30:30Z

I am still absorbing the best practices for committing to solidus_admin, but based on my review I see no reason why we could not merge this. I welcome your feedback and expertise, though.

Store deletion can be aborted if we are deleting a default store, so we'll show alert in that case.

We don't have to use turbo_frames on these pages since we are not loading content into it but always do a page visit to /new and /edit routes, and when server responds with 422 and templates with validation errors we can just place relevant "id" on the topmost element of the page so its content will be replaced with turbo stream.

To fix the following issues: standard: Use Ruby Standard Style (https://github.com/standardrb/standard) admin/app/components/solidus_admin/stores/form/component.rb:14:15: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:35:15: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:36:35: Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash. admin/app/components/solidus_admin/stores/index/component.rb:37:8: Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. admin/app/components/solidus_admin/stores/index/component.rb:46:21: Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. admin/app/components/solidus_admin/stores/index/component.rb:56:54: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:65:53: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:74:54: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:83:36: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/components/solidus_admin/stores/index/component.rb:83:64: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/controllers/solidus_admin/stores_controller.rb:26:26: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. admin/app/controllers/solidus_admin/stores_controller.rb:26:36: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. admin/app/controllers/solidus_admin/stores_controller.rb:26:80: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. admin/app/controllers/solidus_admin/stores_controller.rb:26:82: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. admin/app/controllers/solidus_admin/stores_controller.rb:28:28: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/app/controllers/solidus_admin/stores_controller.rb:51:30: Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. admin/spec/requests/solidus_admin/stores_spec.rb:4:9: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/spec/requests/solidus_admin/stores_spec.rb:9:20: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/spec/requests/solidus_admin/stores_spec.rb:9:46: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. admin/spec/requests/solidus_admin/stores_spec.rb:11:31: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. admin/spec/requests/solidus_admin/stores_spec.rb:11:118: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. admin/spec/requests/solidus_admin/stores_spec.rb:12:33: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. admin/spec/requests/solidus_admin/stores_spec.rb:12:42: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. core/spec/models/spree/store_spec.rb:145:58: Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. standard: Run `standardrb --fix` to fix up to 24 problems. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash. Error: Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. Error: Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Error: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside { detected. Error: Layout/SpaceInsideHashLiteralBraces: Space inside } detected. Error: Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. Error: Process completed with exit code 1.

tvdeyen

Works great. Thanks for taking this over.

tvdeyen · 2026-09-09T08:04:23Z

I am still absorbing the best practices for committing to solidus_admin, but based on my review I see no reason why we could not merge this. I welcome your feedback and expertise, though.

That's what I post to everyone asking me about commit messages: https://cbea.ms/git-commit/

Especially this

Use the body to explain what and why vs. how

I don't have to add much to that :)

benjaminwil requested a review from a team as a code owner September 8, 2026 19:22

github-actions Bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Sep 8, 2026

github-project-automation Bot added this to Solidus Admin Sep 8, 2026

benjaminwil force-pushed the admin-stores-add-edit branch from 914aa77 to f9b25d2 Compare September 8, 2026 19:28

benjaminwil force-pushed the admin-stores-add-edit branch 2 times, most recently from 4ffd364 to aceb5cb Compare September 8, 2026 22:45

benjaminwil marked this pull request as draft September 8, 2026 23:06

chaimann and others added 15 commits September 8, 2026 16:42

Update index component with new link style rows

2294a17

Add components for store page form

45f2268

Update stores resource to be used with new form

c54e6d3

Populate store form page with fields

28b4a8e

Add helper .delete method for button component

af02de9

Add footer actions to the form

01e43f2

Prepend store's before_destroy callback and throw :abort

bfee596

Document accepted option

af7c476

Add missing translation strings

5e5ecd2

Override #destroy action on stores controller

74c9b15

Store deletion can be aborted if we are deleting a default store, so we'll show alert in that case.

Add feature tests

181ab1e

Add request tests

76c09f7

Add missing model test

94f3b84

benjaminwil force-pushed the admin-stores-add-edit branch from aceb5cb to f7c77a8 Compare September 8, 2026 23:49

benjaminwil self-assigned this Sep 9, 2026

benjaminwil marked this pull request as ready for review September 9, 2026 00:04

benjaminwil moved this to Review in Solidus Admin Sep 9, 2026

benjaminwil mentioned this pull request Sep 9, 2026

Admin stores add edit #6228

Closed

4 tasks

tvdeyen approved these changes Sep 9, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

[solidus_admin] Add stores editor - #6589

[solidus_admin] Add stores editor#6589
benjaminwil wants to merge 15 commits into
solidusio:mainfrom
benjaminwil:admin-stores-add-edit

benjaminwil commented Sep 8, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

benjaminwil commented Sep 8, 2026

Uh oh!

tvdeyen left a comment

Uh oh!

tvdeyen commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

benjaminwil commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

codecov Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

benjaminwil commented Sep 8, 2026

Uh oh!

tvdeyen left a comment

Choose a reason for hiding this comment

Uh oh!

tvdeyen commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benjaminwil commented Sep 8, 2026 •

edited

Loading

codecov Bot commented Sep 8, 2026 •

edited

Loading