Improve Stock Coordinator Extensibility - #6527
Draft
sofiabesenski4 wants to merge 10 commits into
Draft
Conversation
github-actions
Bot
added
the
changelog:solidus_core
Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
The initializer doesn't need to handle this. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
This was obfuscating a method call order dependency. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
Stock location filtering is not needed anywhere else in this class. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
These are separate processes that can be reorganized into separate classes in the future. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
Inventory units are not relevant to any other processes. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Senem Soy <senem@super.gd>
sofiabesenski4
force-pushed
the
sofia/oss-3-make-the-coordinator-easily-extensible
branch
from
July 30, 2026 19:04
214a20c to
5930fbb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6527 +/- ##
==========================================
- Coverage 95.07% 92.27% -2.81%
==========================================
Files 460 997 +537
Lines 7924 20517 +12593
==========================================
+ Hits 7534 18932 +11398
- Misses 390 1585 +1195 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jarednorman
changed the title
sofiabesenski4
force-pushed
the
sofia/oss-3-make-the-coordinator-easily-extensible
branch
from
August 19, 2026 21:59
5930fbb to
5c181c6
Compare
5 tasks
Choosing which stock locations to allocate inventory from is a shipping concern rather than a coordination one. The coordinator now receives the stock locations it should use, which frees it from the location filter and sorter configuration. SimpleCoordinator accepts the new keyword argument too, since it is still the configured coordinator_class. It keeps filtering and sorting on its own when no stock locations are given, so its behaviour is unchanged. This also fixes a NameError in Coordinator#build_packages, which reached for the inventory unit builder class through a reader that does not exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sofiabesenski4
force-pushed
the
sofia/oss-3-make-the-coordinator-easily-extensible
branch
from
September 2, 2026 17:17
5c181c6 to
f5792ed
Compare
This will help with under the hood optimizations using Object Shapes.
There was a lot of package specific logic included in the coordinator, which is supposed to be a higher level orchestration class. By moving this into a dedicated object, we can add an extension point, as well as clean up the responsibilities of the new Coordinator. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5855.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: