Delegate create_proposed_shipments to Spree::OrderShipping#6509
Open
sofiabesenski4 wants to merge 2 commits into
Open
Delegate create_proposed_shipments to Spree::OrderShipping#6509sofiabesenski4 wants to merge 2 commits into
sofiabesenski4 wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
changelog:solidus_core
sofiabesenski4
force-pushed
the
introduce-extensible-stock-coordinator
branch
from
June 30, 2026 20:53
4254f84 to
6b07b2c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6509 +/- ##
==========================================
+ Coverage 89.68% 92.02% +2.34%
==========================================
Files 991 1035 +44
Lines 20832 21127 +295
==========================================
+ Hits 18683 19442 +759
+ Misses 2149 1685 -464 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sofiabesenski4
force-pushed
the
introduce-extensible-stock-coordinator
branch
from
June 30, 2026 21:09
6b07b2c to
1fdef1d
Compare
mamhoff
approved these changes
Jul 14, 2026
mamhoff
left a comment
mamhoff
left a comment
Contributor
There was a problem hiding this comment.
I really like this. I think it'd be good to also move the error to OrderShipping and deprecate Spree::Order::CannotRebuildShipments, as it's really part of the API of #create_proposed_shipments.
sofiabesenski4
marked this pull request as ready for review
July 16, 2026 17:41
sofiabesenski4
force-pushed
the
introduce-extensible-stock-coordinator
branch
from
July 16, 2026 17:45
1fdef1d to
6d94924
Compare
Contributor
Author
|
I'm going to break out some of the linter fixes into their own commit. |
Spree::OrderShipping is a configurable class, which increases the extensibility for this system behaviour. The Spree::Order model also shouldn't need to be responsible for the creation of its own shipments. Separating this concern will allow us to refactor the underlying stock coordination implementation without introducing additional churn on the already heavy Spree::Order class. Co-authored-by: Adam Mueller<adam@super.gd>
Correct block indentation in Stock::Estimator and remove redundant map(&:to_s) before join in Store and Variant::PricingOptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sofiabesenski4
force-pushed
the
introduce-extensible-stock-coordinator
branch
from
July 16, 2026 17:49
6d94924 to
5a57d65
Compare
jarednorman
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(From the first commit message)
Spree::OrderShipping is a configurable class, which increases the extensibility for this system behaviour. The Spree::Order model also shouldn't need to be responsible for the creation of its own shipments.
Separating this concern will allow us to refactor the underlying stock coordination implementation without introducing additional churn on the already heavy Spree::Order class.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: