chore(size): batch re-record after #4653, #4655, #4657, #4659 and #4654 by ryansolid · Pull Request #4664 · solidjs/solid

ryansolid · 2026-11-03T10:13:07Z

Summary

This is the batch re-record of the size ledger after #4653, #4655, #4657, #4659 and #4654 merged. The numbers come from next's push Size run at ccfc7ea (head job 125848841075). Hello world is unchanged at 9,974 B, and its 9.98 KB cap is untouched.

Size-Exception: frozen floors re-recorded after the batch. The maintainer accepted the growth from #4653 (an Errored heals when nothing reads the failed source any more, about +131 B minified on the Errored rows), #4655 (the #4639 follow-up hiddenBy walk, +55 B minified on Loading/Errored rows) and #4659 (an unserializable async value rejects, +24 B minified on renderToString). The live rows carry about +20 B minified more, from #4657 (accepted with its batch); #4654 is size-neutral. The hydrating floor goes from 18.97 KB to 19.05 KB, base server components from 33.95 KB to 34.11 KB, live server components from 39.92 KB to 39.96 KB, and renderToString's recorded minified from 77,768 to 77,792 B (cap unchanged).

scenario	cap	recorded minified
app: hydrating	18.97 KB -> 19.05 KB	53,906 -> 54,092 (frozen floor)
app: hydrating + every store primitive family	32.98 KB -> 33.12 KB	99,451 -> 99,641
app: CSR with Show/For/Loading/Errored/lazy	13.65 KB -> 13.73 KB	37,377 -> 37,563
app: CSR, observe tier	15.41 KB -> 15.50 KB	42,327 -> 42,513
app: CSR, observe tier + attribution engine enabled	30.03 KB -> 30.12 KB	88,656 -> 88,842
app: compiled CSR	26.54 KB -> 26.57 KB	80,314 -> 80,500
app: compiled hydrating	32.79 KB -> 32.87 KB	101,034 -> 101,221
page: base server components	33.95 KB -> 34.11 KB	102,026 -> 102,212 (frozen floor)
page: live server components	39.92 KB -> 39.96 KB	120,104 -> 120,310 (frozen floor)
page: compiled base server components	35.93 KB -> 36.00 KB	108,360 -> 108,546
page: compiled live server components	43.97 KB -> 44.05 KB	128,356 -> 128,562
page: base + router	41.53 KB -> 41.57 KB	126,108 -> 126,300
page: live + router	49.63 KB -> 49.78 KB	145,917 -> 146,123
server: renderToString	22.87 KB (unchanged)	77,768 -> 77,792 (frozen floor)

How did you test this change?

The numbers are next's push Size job measurements (the failing rows' over-cap amounts and recorded minified), cross-checked with a local run at ccfc7ea that matches byte for byte on every non-compiled row.
Ran prettier on scripts/size.

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

changeset-bot · 2026-11-03T10:13:14Z

⚠️ No Changeset found

Latest commit: f766012

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-11-03T10:16:13Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	−91 B	7.43 KB	✅
signals: + createStore	15.01 KB	0 B	15.03 KB	✅
signals: + isPending/latest	11.90 KB	0 B	11.92 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	−84 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.80 KB	−150 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	19.04 KB	0 B	19.05 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	33.11 KB	0 B	33.12 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.71 KB	0 B	13.73 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.48 KB	0 B	15.50 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	30.11 KB	0 B	30.12 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	−187 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.56 KB	0 B	26.57 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.86 KB	0 B	32.87 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	34.10 KB	0 B	34.11 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.22 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.94 KB	0 B	39.96 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.24 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.99 KB	0 B	36.00 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.17 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	44.04 KB	0 B	44.05 KB	✅	eager (counted): web.js 23.52 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.22 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.56 KB	0 B	41.57 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.20 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	49.77 KB	0 B	49.78 KB	✅	eager (counted): client.js 28.75 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.22 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.86 KB	0 B	22.87 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-11-03T10:22:28Z

Coverage Report for CI Build 41617412153

Coverage remained the same at 78.249%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1370
Covered Lines:	1132
Line Coverage:	82.63%
Relevant Branches:	1108
Covered Branches:	807
Branch Coverage:	72.83%
Branches in Coverage %:	Yes
Coverage Strength:	30.08 hits per line

💛 - Coveralls

codspeed · 2026-11-03T10:37:20Z

Merging this PR will degrade performance by 10.62%

2 warnings

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

❌ 1 regressed benchmark
✅ 199 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`arrow in template`	11 ms	12.3 ms	-10.62%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/size-rerecord-13 (f766012) with next (ccfc7ea)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chore(size): batch re-record after #4653, #4655, #4657, #4659 and #4654

f766012

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

ryansolid merged commit a4a0720 into next Nov 3, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(size): batch re-record after #4653, #4655, #4657, #4659 and #4654 - #4664

chore(size): batch re-record after #4653, #4655, #4657, #4659 and #4654#4664
ryansolid merged 1 commit into
nextfrom
claude/size-rerecord-13

ryansolid commented Nov 3, 2026

Uh oh!

changeset-bot Bot commented Nov 3, 2026

Uh oh!

github-actions Bot commented Nov 3, 2026

Uh oh!

coveralls commented Nov 3, 2026

Uh oh!

Uh oh!

codspeed Bot commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Nov 3, 2026

Summary

How did you test this change?

Uh oh!

changeset-bot Bot commented Nov 3, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Nov 3, 2026

Size (brotli, eager entry chunk)

Uh oh!

coveralls commented Nov 3, 2026

Coverage Report for CI Build 41617412153

Coverage remained the same at 78.249%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

codspeed Bot commented Nov 3, 2026

Merging this PR will degrade performance by 10.62%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants