Skip to content

chore(size): batch re-record after #4639 and #4641 - #4652

Merged
ryansolid merged 1 commit into
nextfrom
claude/size-rerecord-4639-4641
Nov 3, 2026
Merged

ryansolid merged 1 commit into
nextfrom
claude/size-rerecord-4639-4641

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Summary

This is the batch re-record of the size ledger after #4639 and #4641 merged. The numbers come from next's push Size run at 6e569c7 (head job 125766182293). Hello world is unchanged at 9,974 B, and its 9.98 KB cap is untouched.

Size-Exception: frozen floors re-recorded after the batch. The maintainer accepted the growth from #4639 (a pending error-boundary output read only behind fallbacks holds nothing, +74 B minified on the app rows) and from #4641 (a memo over an error boundary's output no longer halts on a held rejection, +47 B minified on the isPending/latest rows). The hydrating floor goes from 18.94 KB to 18.97 KB, base server components from 33.92 KB to 33.95 KB, and live server components from 39.82 KB to 39.92 KB.

scenario cap recorded minified
signals: + isPending/latest 11.91 KB -> 11.92 KB 32,725 -> 32,772
app: hydrating 18.94 KB -> 18.97 KB 53,832 -> 53,906 (frozen floor)
app: hydrating + every store primitive family 32.96 KB -> 32.98 KB 99,377 -> 99,451
app: CSR with Show/For/Loading/Errored/lazy 13.64 KB -> 13.65 KB 37,303 -> 37,377
app: CSR, observe tier 15.40 KB -> 15.41 KB 42,253 -> 42,327
app: CSR, observe tier + attribution engine enabled 30.03 KB (unchanged) 88,582 -> 88,656
app: compiled CSR 26.51 KB -> 26.54 KB 80,240 -> 80,314
app: compiled hydrating 32.79 KB (unchanged) 100,960 -> 101,034
page: base server components 33.92 KB -> 33.95 KB 101,947 -> 102,026 (frozen floor)
page: live server components 39.82 KB -> 39.92 KB 119,983 -> 120,104 (frozen floor)
page: compiled base server components 35.93 KB (unchanged) 108,286 -> 108,360
page: compiled live server components 43.87 KB -> 43.97 KB 128,235 -> 128,356
page: base + router 41.53 KB (unchanged) 126,040 -> 126,108
page: live + router 49.63 KB (unchanged) 145,796 -> 145,917

How did you test this change?

  • The numbers are CI's measurements from next's push Size job, not local ones.
  • Ran prettier on scripts/size.

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
@changeset-bot

changeset-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0ca1d1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.42 KB 0 B 0 B −91 B 7.43 KB ✅
signals: + createStore 15.01 KB 0 B 0 B 0 B 15.03 KB ✅
signals: + isPending/latest 11.90 KB 0 B 0 B 0 B 11.92 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.05 KB 0 B 0 B −84 B 8.06 KB ✅
app: render + one signal (the simple-app floor) 9.80 KB 0 B 0 B −150 B 9.80 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.96 KB 0 B 0 B 0 B 18.97 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 32.97 KB 0 B 0 B 0 B 32.98 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.63 KB 0 B 0 B 0 B 13.65 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.40 KB 0 B 0 B 0 B 15.41 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 30.01 KB 0 B 0 B 0 B 30.03 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.97 KB 0 B 0 B −187 B 9.98 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.52 KB 0 B 0 B 0 B 26.54 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.76 KB 0 B 0 B 0 B 32.79 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.93 KB 0 B 0 B 0 B 33.95 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.22 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest) 39.90 KB 0 B 0 B 0 B 39.92 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.24 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.91 KB 0 B 0 B 0 B 35.93 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.17 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 43.96 KB 0 B 0 B 0 B 43.97 KB ✅ eager (counted): web.js 23.44 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.22 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.44 KB 0 B 0 B 0 B 41.53 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.20 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 49.61 KB 0 B 0 B 0 B 49.63 KB ✅ eager (counted): client.js 28.59 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.22 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.29 KB ✅
server: renderToString (the server-render floor) 22.86 KB 0 B 0 B 0 B 22.87 KB ✅

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 41591099415

Coverage remained the same at 78.205%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1369
Covered Lines: 1131
Line Coverage: 82.62%
Relevant Branches: 1104
Covered Branches: 803
Branch Coverage: 72.74%
Branches in Coverage %: Yes
Coverage Strength: 30.07 hits per line

💛 - Coveralls

@ryansolid
ryansolid merged commit 6f33602 into next Nov 3, 2026
8 checks passed
@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 5.73%

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 2 improved benchmarks
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ arrow in template 12.4 ms 11.6 ms +6.43%
⚡ polymorphic-chain mount+clear 1000 rows: compiled 424.2 ms 403.8 ms +5.05%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/size-rerecord-4639-4641 (0ca1d1e) with next (6e569c7)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants