chore(size): re-record ledger after #4614 and #4615 by ryansolid · Pull Request #4619 · solidjs/solid

ryansolid · 2026-11-02T09:53:40Z

Size-Exception: re-record after #4614 and #4615, whose growth the maintainer accepted. One frozen floor is re-recorded: "page: live server components" keeps its 39.32 KB cap and its recorded minified goes from 118,432 to 118,440 B (+8 B, from #4614).

Before: next @ 7ea8706 fails the size gate on the router rows with #4615's accepted growth, which also turns the size check red on every open PR.

After: every row CI measured above its recorded minified, or over its cap, is re-recorded.

The numbers come from next's own push size job, 125205107698 at 7ea8706. Caps are measured brotli + 10 B, rounded up to 0.01 KB, and never lowered. Recorded minified equals the measured value.

Row	Cap	Recorded minified
signals: + isPending/latest	11.47 → 11.48 KB	31,386 → 31,394
app: hydrating + every store	32.90 KB (unchanged)	99,155 → 99,163
page: live server components (frozen floor)	39.32 KB (unchanged)	118,432 → 118,440
page: compiled live server components	43.30 KB (unchanged)	126,622 → 126,630
page: base + router	41.36 → 41.43 KB	125,770 → 125,844
page: live + router	49.00 → 49.08 KB	144,106 → 144,195

Hello world (app: compiled floor) is 9,974 B and keeps its 9.98 KB cap.

Generated by Claude Code

Numbers from next's push size job 125205107698 at 7ea8706. Hello world stays under its 9.98 KB cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

changeset-bot · 2026-11-02T09:53:55Z

⚠️ No Changeset found

Latest commit: ca5df78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-11-02T09:56:56Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	−91 B	7.43 KB	✅
signals: + createStore	15.00 KB	0 B	15.01 KB	✅
signals: + isPending/latest	11.47 KB	0 B	11.48 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	−84 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.80 KB	−150 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.91 KB	0 B	18.93 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.84 KB	0 B	32.90 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.55 KB	0 B	13.57 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.32 KB	0 B	15.33 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.91 KB	0 B	29.93 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	−187 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.40 KB	0 B	26.41 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.65 KB	0 B	32.66 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.89 KB	0 B	33.91 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.27 KB	0 B	39.32 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.83 KB	0 B	35.84 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	43.29 KB	0 B	43.30 KB	✅	eager (counted): web.js 23.13 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.41 KB	0 B	41.43 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	49.06 KB	0 B	49.08 KB	✅	eager (counted): client.js 28.39 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.14 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.85 KB	0 B	22.87 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-11-02T10:06:16Z

Coverage Report for CI Build 41424348114

Coverage remained the same at 78.205%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1369
Covered Lines:	1131
Line Coverage:	82.62%
Relevant Branches:	1104
Covered Branches:	803
Branch Coverage:	72.74%
Branches in Coverage %:	Yes
Coverage Strength:	30.09 hits per line

💛 - Coveralls

codspeed · 2026-11-02T10:19:11Z

Merging this PR will improve performance by 27.22%

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 1 improved benchmark
✅ 199 untouched benchmarks
⏩ 5 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`projection derive: write one NESTED field (reference)`	2.7 ms	2.1 ms	+27.22%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/size-ledger-4614-4615 (ca5df78) with next (7ea8706)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chore(size): re-record ledger after #4614 and #4615

ca5df78

Numbers from next's push size job 125205107698 at 7ea8706. Hello world stays under its 9.98 KB cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

ryansolid merged commit 9449845 into next Nov 2, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(size): re-record ledger after #4614 and #4615 - #4619

chore(size): re-record ledger after #4614 and #4615#4619
ryansolid merged 1 commit into
nextfrom
claude/size-ledger-4614-4615

ryansolid commented Nov 2, 2026

Uh oh!

changeset-bot Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

Uh oh!

coveralls commented Nov 2, 2026

Uh oh!

codspeed Bot commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Nov 2, 2026

Uh oh!

changeset-bot Bot commented Nov 2, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Nov 2, 2026

Size (brotli, eager entry chunk)

Uh oh!

Uh oh!

coveralls commented Nov 2, 2026

Coverage Report for CI Build 41424348114

Coverage remained the same at 78.205%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Nov 2, 2026

Merging this PR will improve performance by 27.22%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants