chore(size): re-record the ledger after the third 2026-10-30 batch (#4512, #4506, #4509, #4508) by ryansolid · Pull Request #4514 · solidjs/solid

ryansolid · 2026-10-30T22:33:30Z

Before: on next @ 71a6a75, every open PR fails the size gate on server: renderToString. After #4512 (low-priority modulepreload hints), it measures 22,854 B brotli against its frozen 22.80 KB cap, +266 B minified over its record. app: render + one signal measures 9,781 B, 1 B over its frozen 9.78 KB cap, with 5 B of minified allowance left. #4508 (#4444) can't pass on its own router growth either.

After: every scenario is within its cap, measured against what next builds now, and #4508's router rows are recorded ahead of its merge.

This is a ledger-only PR, per the batch process: fix PRs carry no scripts/size edits, and the ledger is re-recorded once per batch.

How: measured over next @ 71a6a75 (linux). Caps are set at brotli + 10 B, rounded up to 0.01 KB.

server: renderToString (frozen floor): 22.80 → 22.87 KB, minified 77,473 → 77,739
app: render + one signal (frozen floor): 9.78 → 9.80 KB, minified 26,739 → 26,754
page: compiled live server components: 43.01 → 43.02 KB, minified 126,181 → 126,196
Recorded minified only (caps unchanged), where fix(signals): a memo over a re-asked async memo is born held with the mount that first reads it (#4504) #4509 moved it by +15 B: signals core floor (frozen, 19,908 → 19,923), isPending/latest (31,245 → 31,260), live server components (frozen, 118,033 → 118,048)
fix(signals): createOwner's dispose works when called detached (#4444) #4508 (bound dispose on the public createOwner, which @solidjs/router calls). These numbers are from fix(signals): createOwner's dispose works when called detached (#4444) #4508's CI head, a4ab913, which matches local:
- page: live + router: 48.65 → 48.67 KB, minified 143,439 → 143,527 (+15 B from fix(signals): a memo over a re-asked async memo is born held with the mount that first reads it (#4504) #4509, +73 B from fix(signals): createOwner's dispose works when called detached (#4444) #4508)
- page: base + router: recorded minified only, 125,539 → 125,596 (+57 B). It stays under its 41.25 KB cap.
- The maintainer accepted this growth on 2026-10-30, with a router follow-up to win it back.

Hello world is 9,971 B (cap 9.98 KB). The build leaves the pinned mangle-props.json unchanged.

Size-Exception: server: renderToString +266 B minified / +54 B over cap from #4512 (low-priority modulepreload), server-only, maintainer approved 2026-10-30; the simple-app floor and the +15 B re-records are #4509's approved growth, within the 20 B allowance; #4508's router growth accepted by the maintainer 2026-10-30.

🤖 Generated with Claude Code

https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

…4512, #4506, #4509) next @ 71a6a75 fails the size gate on server: renderToString after #4512 (low-priority modulepreload hints): 22,854 B brotli against the frozen 22.80 KB cap, +266 B minified over its record. Re-records, measured over next @ 71a6a75 (linux): - server: renderToString (frozen floor): 22.80 -> 22.87 KB, minified 77,473 -> 77,739 - app: render + one signal (frozen floor): 9.78 -> 9.80 KB, minified 26,739 -> 26,754 (it measured 9,781 B, 1 B over its cap, with 5 B of minified allowance left) - page: compiled live server components: 43.01 -> 43.02 KB, minified 126,181 -> 126,196 and the recorded minified only (caps unchanged) where #4509 moved it +15 B: signals core floor (frozen, 19,908 -> 19,923), isPending/latest (31,245 -> 31,260), live server components (frozen, 118,033 -> 118,048), live + router (143,439 -> 143,454). Hello world is 9,971 B (cap 9.98 KB). The build leaves the pinned mangle-props.json unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-30T22:33:38Z

⚠️ No Changeset found

Latest commit: 0059f68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-30T22:36:39Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	0 B	7.43 KB	✅
signals: + createStore	14.98 KB	0 B	14.99 KB	✅
signals: + isPending/latest	11.35 KB	0 B	11.35 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	+2 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	0 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.73 KB	0 B	18.74 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.48 KB	0 B	32.48 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.45 KB	+9 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.19 KB	+9 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.78 KB	+9 B	29.78 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	+2 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.35 KB	0 B	26.36 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.48 KB	0 B	32.54 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.72 KB	0 B	33.77 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.17 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.05 KB	0 B	39.10 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.19 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.71 KB	0 B	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.14 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	43.01 KB	0 B	43.02 KB	✅	eager (counted): web.js 22.99 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.11 KB	−57 B	41.25 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.11 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.62 KB	−73 B	48.67 KB	✅	eager (counted): client.js 28.11 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.13 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.85 KB	0 B	22.87 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

#4508 (#4444) binds `dispose` on the public `createOwner`, which @solidjs/router calls, so the router pages pay the bind. The maintainer accepted the growth on 2026-10-30, with a router follow-up to win it back. Recorded from #4508's CI head a4ab913 (matches local): - page: live + router: 48.65 -> 48.67 KB, minified 143,454 -> 143,527 - page: base + router: recorded minified 125,539 -> 125,596 (cap unchanged at 41.25 KB) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

coveralls · 2026-10-30T22:45:36Z

Coverage Report for CI Build 41139911085

Coverage remained the same at 78.1%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1362
Covered Lines:	1125
Line Coverage:	82.6%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.89 hits per line

💛 - Coveralls

codspeed · 2026-10-30T22:57:24Z

Merging this PR will degrade performance by 15.33%

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

❌ 2 regressed benchmarks
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`projection derive: write one NESTED field (reference)`	2.1 ms	2.7 ms	-22.21%
❌	`memo + sync render effect only (reference)`	31.9 ms	34.7 ms	-7.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-ledger-71a6a75 (0059f68) with next (71a6a75)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ryansolid mentioned this pull request Oct 30, 2026

fix(signals): createOwner's dispose works when called detached (#4444) #4508

Closed

ryansolid changed the title ~~chore(size): re-record the ledger after the third 2026-10-30 batch (#4512, #4506, #4509)~~ chore(size): re-record the ledger after the third 2026-10-30 batch (#4512, #4506, #4509, #4508) Oct 30, 2026

ryansolid merged commit e6c2f3b into next Oct 30, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(size): re-record the ledger after the third 2026-10-30 batch (#4512, #4506, #4509, #4508) - #4514

chore(size): re-record the ledger after the third 2026-10-30 batch (#4512, #4506, #4509, #4508)#4514
ryansolid merged 2 commits into
nextfrom
claude/project-thread-x1ore2-ledger-71a6a75

ryansolid commented Oct 30, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

coveralls commented Oct 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

codspeed Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size (brotli, eager entry chunk)

Uh oh!

coveralls commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 41139911085

Coverage remained the same at 78.1%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

codspeed Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 15.33%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ryansolid commented Oct 30, 2026 •

edited

Loading

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

github-actions Bot commented Oct 30, 2026 •

edited

Loading

coveralls commented Oct 30, 2026 •

edited

Loading

codspeed Bot commented Oct 30, 2026 •

edited

Loading