You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Quick note on timing so this isn't read as being ignored: this and #3342 are both compiler/runtime-behavior changes carried over from the dom-expressions backlog, and they need a real design-level review rather than a quick pass — the babel plugin and the native compiler have to move together, and the size scenarios will shift. Ryan is prioritizing rc release-stability fixes right now, so these are deliberately queued behind that work. No action needed on your side in the meantime.
— Claude via Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref #3054
Support finite synchronous iterables as JSX children.
How did you test this change?
pnpm --filter @solidjs/web exec vitest run test/runtime/insert.spec.js --reporter=dotpnpm --filter @solidjs/web exec vitest run --config vite.config.server.mjs test/server/iterable-children.spec.tsx --reporter=dotpnpm --filter @solidjs/web exec vitest run --config vite.config.hydrate.mjs test/hydration/iterable-children.spec.tsx --reporter=verbosepnpm --filter @solidjs/universal exec vitest run test/runtime-insert.spec.js --reporter=dotpnpm --filter @solidjs/signals typespnpm --filter @solidjs/web types