fix(compiler): preserve coverage pragmas in JSX

[nickshiro]

Summary

ref #2138

Preserve JSX Istanbul ignore comments when compiling component children, and annotate compiler-generated ref dispatch branches so they do not count toward coverage.

• Add /* istanbul ignore next */ annotations to compiler-generated conditional ref dispatches.
• Add regression coverage.

How did you test this change?

• pnpm --filter @solidjs/babel-plugin exec vitest run
  28 test files passed, 259 tests passed

• pnpm --filter @solidjs/babel-plugin typecheck

[changeset-bot]

🦋 Changeset detected

Latest commit: 961bd14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@solidjs/babel-plugin	Patch
@solidjs/compiler	Patch
test-integration	Patch
@solidjs/diagnostics	Patch
@solidjs/element	Patch
@solidjs/h	Patch
@solidjs/html	Patch
@solidjs/signals	Patch
solid-js	Patch
@solidjs/universal	Patch
@solidjs/web	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

Merging this PR will not alter performance

✅ 142 untouched benchmarks

---

_{Comparing nickshiro:fix/compiler-istanbul-comments (4361585) with next (b6a90f9)}

[ryansolid]

Thanks for taking this on — half of it is exactly what we want, and the diff splits cleanly along that line.

Keep: preserving the user's own pragma. A {/* istanbul ignore next */} the author wrote in JSX should survive onto the get children() getter the compiler emits. That is comment fidelity for a deliberate annotation, and it's the right layer for it. Two asks on this half:

• Match c8 ignore alongside istanbul ignore (/^\s*(istanbul|c8)\s+ignore\b/). v8-based coverage is what most Vitest users run now, and it's the same regex.
• Oxc parity. The Babel plugin and packages/compiler share codegen expectations; the same carry-through needs to land in the native compiler with the shared fixture before this can merge.

Drop: injecting /* istanbul ignore next */ on the generated ref dispatch. This is the part that touches dom/element.ts, universal/element.ts, and rewrites fourteen fixture outputs, and we don't want it — not for size, on principle:

• The compiler would be emitting a specific tool's pragma into every user's output. That's tool knowledge in the wrong layer, and it doesn't stop at one vendor.
• Coverage of compiler-generated branches is the coverage tool's problem, and the tools have been solving it: v8 coverage with AST-aware remapping attributes back through the source map to the JSX, where there is no branch. Instrumenting post-compile output with Istanbul is the configuration that produces the phantom branches.
• Every injected comment is dev-build bytes for everyone and one more thing both compilers must mirror forever.

If real demand shows up later, an explicit opt-in is the ceiling we'd consider, but we'd rather not add it speculatively.

Also: @solidjs/web#test-types is red on this branch. It's probably the base (next moved on Sep 7); a rebase should tell.

Once it's down to the preserve half + c8 + Oxc parity, happy to merge.

— Claude via Cursor

[nickshiro]

• Removed all automatically injected coverage comments from generated ref dispatches.
• Preserved only user-authored JSX pragmas, now supporting both istanbul ignore and c8 ignore.
• Added Oxc parity for DOM, Universal, and SSR.
• Added a shared fixture consumed by the Babel and native compiler regression tests.

Thanks for your review!

[ryansolid]

This is now exactly the shape we asked for — thanks. The injection is gone, the (istanbul|c8)\s+ignore\b match is right, and the Oxc port is a real one (the closing-} span trick for comment attachment is a good way to do it) with the shared fixture driving both compilers.

One blocker: the native compiler doesn't build. source() was added to the ModeLower trait and implemented for AstDomTransform and AstUniversalTransform, but AstSsrTransform (packages/compiler/src/ssr/transform.rs, the impl ModeLower near the bottom) was missed:

error[E0046]: not all trait items implemented, missing: `source`

Same three lines as the other two impls:

fn source(&self) -> &str {
    self.source
}

Please also rebase onto next — the CodSpeed and Size failures are inherited from the base at the time you branched and will clear — and run the Rust side before pushing (cargo build / pnpm --filter @solidjs/compiler test), since the JS tests alone can't see this.

Two nits, take or leave: the Babel test is in ref-spread.spec.js, which is about intrinsic ref/spread sources — a coverage-pragmas.spec.js (or the shared-fixtures runner) would be a more findable home. And the Oxc path re-emits every comment ahead of the }, so {/* note */ /* c8 ignore next */} prints both where Babel prints only the pragma; fine as is, just noting the fidelity difference.

Once it builds green this merges.

— Claude via Cursor