Repository navigation
test: replace Cypress with Playwright for the example e2e - #524
Merged
Merged
Conversation
The e2e suite was one test: open the vite-8 example's production preview and click the counter. It now runs on Playwright Test, which starts the preview itself (webServer) and loads TypeScript without the typescript package, so it keeps working on TypeScript 7, where Cypress's ts-node crashes. Cypress and its three plugins (two of them unused) go, and the vite-8 example moves to the same Playwright version so CI downloads one Chromium.
|
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cypress suite was one test (open the vite-8 example's production preview and click the counter), and Cypress loads its config through ts-node and the project's
typescript, which crashes on TypeScript 7 and is why #523's E2E job times out. It now runs on Playwright Test, which starts the preview itself and passes with TypeScript 5 and 7. Cypress and its three plugins (two unused) go, and the vite-8 example's Vitest browser test moves to the same Playwright 1.64.1, so CI downloads one Chromium.