Add issue 2108 scroll hydration repro#2109
Closed
pRizz wants to merge 1 commit intosolidjs:upgrade-to-solid-2-betafrom
Closed
Add issue 2108 scroll hydration repro#2109pRizz wants to merge 1 commit intosolidjs:upgrade-to-solid-2-betafrom
pRizz wants to merge 1 commit intosolidjs:upgrade-to-solid-2-betafrom
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/testsroute that mirrors issue [Bug?]:2.0.0-alpha.2hydration mismatch on initial scroll with KobalteCollapsibleTriggerandlucide-solidChevronDown#2108 with a sticky shell, Kobalte collapsible trigger, Lucide chevron, and a tall scrolling bodyapps/testsoff@solidjs/metaonto a minimal local meta shim so the app gets past the existing Solid 2 beta meta import breakageVerification
pnpm formatpnpm buildpnpm --filter tests exec playwright install chromiumpnpm --filter tests e2e --grep hydration(fails before loading the repro in this branch because@solidjs/router@0.15.4still imports removed Solid 1 entrypoints; an untouchedorigin/upgrade-to-solid-2-betaworktree also fails before loading the app, first in@solidjs/metawithMissing "./web" specifier in "solid-js" package)Notes
apps/testsfar enough to validate the new repro route and regression spec