Skip to content

Removes await in revalidate uses and sets applyResponseMetadata as sync #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-canton wants to merge 1 commit into
base: next
Choose a base branch
from
+3 −3
Open

Removes await in revalidate uses and sets applyResponseMetadata as sync #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/data/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ export function setupFlightDataConsumer(router: RouterContext) {
* the flight-data consumer and the action response path (which still sees
* metadata-bearing responses when no flight data was collected).
*/
async function applyResponseMetadata(
function applyResponseMetadata(
metadata: Response | undefined,
navigate: Navigator,
flightData?: Record<string, any>
Expand All @@ -446,7 +446,7 @@ async function applyResponseMetadata(
// set cache
flightData && Object.keys(flightData).forEach(k => query.set(k, flightData[k]));
// trigger revalidation
await revalidate(keys, false);
revalidate(keys, false);
}

async function handleResponse(
Expand Down Expand Up @@ -483,6 +483,6 @@ async function handleResponse(
// function's unwrapped value. Do not treat that value as a second plain
// action response and invalidate the freshly seeded query cache again.
if (!metadataHandled || metadata || flightData)
await applyResponseMetadata(metadata, navigate, flightData);
applyResponseMetadata(metadata, navigate, flightData);
return data != null ? { data } : undefined;
}
Loading