Skip to content

perf(core): drop dead 1x1 placeholder upload in the image path #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiefcll merged 1 commit into from
Jun 13, 2026
+5 −4
Merged

perf(core): drop dead 1x1 placeholder upload in the image path #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/core/renderers/webgl/WebGlCtxTexture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,11 @@ export class WebGlCtxTexture extends CoreContextTexture {
);
}

// Set to a 1x1 transparent texture
glw.texImage2D(0, glw.RGBA, 1, 1, 0, glw.RGBA, glw.UNSIGNED_BYTE, null);
this.setTextureMemUse(TRANSPARENT_TEXTURE_DATA.byteLength);

// No placeholder upload here: every branch below fully (re)uploads the
// texture before this method returns, and there is no `await` in between,
// so no frame can render an intermediate 1x1. The empty-texture case
// (`tdata === null`) does its own 1x1 upload. Uploading a throwaway 1x1
// first would be a wasted texImage2D + setTextureMemUse per texture.
let w = 0;
let h = 0;

Expand Down
Loading