Repository navigation
ci(dependency-review): fail only on advisories the base doesn't have - #507
Merged
Merged
Conversation
The dependency-review job failed on a version a pull request adds or moves to that has an advisory of moderate severity or worse, even when the version it replaces had the same advisory. Such a pull request leaves main as it was. Renovate's lock file maintenance ran into it: npm 11.21.0 to 11.21.1 in the NSS 6 test server moves the ip-address that npm bundles from 10.5.0 to 10.7.2, both under GHSA-rxp7-6hxx-x8q5, and no npm 11.x bundles a fixed one yet, so every other update in the pull request was held back. The only way through was allow-ghsas, a waiver for the whole repository that has to be removed by hand. npm run dependencies:review (dependencies:summary before) now judges the advisories from the comparison the job already fetches. An advisory of an added version fails the job unless a removed version of the same package in the same manifest has the same GHSA id: then it is listed as carried over from the base, and the job passes. It matches the advisory, not the package, so a version that fixes one advisory and has another still fails. The run's summary lists both kinds above the package tables. dependency-review-action keeps checking the licenses, with its vulnerability check turned off. Dependabot alerts on main report the advisories main already has. Closes: #506
ixuz
added
enhancement
ixuz
enabled auto-merge
November 2, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The
dependency-reviewjob failed when a pull request added, or moved to, a version with an advisory of moderate severity or worse. It failed even when the version being replaced had the same advisory, so the pull request leftmainexactly as it was. Renovate's lock file maintenance ran into this (run 41425244611):npm11.21.0 → 11.21.1 in the NSS 6 test server moves theip-addressthatnpmbundles from 10.5.0 to 10.7.2.npm11.x bundles a fixed version yet.The job now fails only on advisories the pull request introduces:
npm run dependencies:review(renamed fromdependencies:summary) checks advisories using the comparison the job already fetches:dependency-review-actionnow checks licenses only (vulnerability-check: false).docs/testing.mdsay that Dependabot alerts onmainreport the advisoriesmainalready has.This means an update that stays inside a vulnerable range now passes, even when a fixed version exists.
mainis no worse than before, and Renovate's vulnerability alerts bring the fix.Before merging, check that Dependabot alerts are on (Settings › Advanced Security). Once this is merged, re-running the dependency review on the lock file maintenance pull request should pass, with the
ip-addressadvisory shown as carried over.Closes: #506