feat(efficacy): the change prompt states what its grader drives - #1848
Merged
Merged
Conversation
Round 1's change-task pass rate was withdrawn. The acceptance modules
built the new rule and the cap through names the prompt never gave, so
they graded which trials guessed them. They also checked four rules that
only the private suite wrote down: an ineligible threshold rule is not
reported, construction refuses bad values, the cap is per line, and an
amount at the cap is wholly reduced.
The prompt now names all of it:
- `tariff.ThresholdRule(rule_id, percent=..., minimum=...)` and its
eligibility and slot rules
- `Jurisdiction(..., caps={...})` and the per-line tax formula
- the form fields and pages the web application must accept
The UI half was asked for but never graded. The suite's HTTP cases for
it come with the round-3 suite extension, and design §5.4 now says so.
The harness self test checks that the prompt is read whole from its file
and names every API and field the grader drives. Removing the class name
makes that check fail.
Part of #1767.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Conformance's comment-layout check wants a blank line between a comment block and the code above it. Part of #1767. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1767, the checklist item "Name, in the change prompt, the API the change acceptance module drives".
What changes
change-prompt.txtkeeps its first paragraph word for word and adds two paragraphs:tariff.ThresholdRule(rule_id, percent=..., minimum=...)with its eligibility, slot and refusal rules, andJurisdiction(..., caps={...})with the per-line formula and the at-the-cap rule. These are the names and rules the private acceptance modules check. Until now they were written only in the suite'sCHANGE-TASK.md.kindthresholdwithpercentandminimumon POST/rules;capson POST/jurisdictions, written likerates; and the preview pricing with both.Not in this PR
The suite's HTTP cases for the UI half. They need sign-in, which lands with the round-3 suite extension (the next #1767 step).
Evidence
tariff.ThresholdRulein the prompt (the mutation landed: one occurrence) makes the new check fail (93/94). The file was then restored and compared byte for byte.Changelog
No entry. This changes the benchmark's own trial input and tooling.
🤖 Generated with Claude Code