js: Add tests for BurnChecked instruction#119
Merged
joncinque merged 2 commits intosolana-program:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
Author
|
@joncinque @timkoopmans The review has been pending for a long time — please take a look once |
timkoopmans
approved these changes
Mar 15, 2026
joncinque
reviewed
Mar 19, 2026
Contributor
joncinque
left a comment
There was a problem hiding this comment.
Apologies for the slow review, this wasn't very high priority unfortunately, but we do appreciate your contribution.
I'll kick off CI, but I think we just need to remove some of these tests and we can merge it
Contributor
|
Actually, can you rebase your branch? We won't be able to run CI otherwise |
59782d0 to
34374c1
Compare
Contributor
Author
|
Done @joncinque
|
Contributor
|
Looks like formatting is failing -- can you run |
Contributor
Author
done |
joncinque
approved these changes
Mar 20, 2026
Contributor
joncinque
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a dedicated test suite for the
BurnCheckedinstruction inclients/jsChanges:
clients/js/test/burnChecked.test.ts.