openapi-codegen: support components.headers - #5476
Draft
magdzikk wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openapi-codegendecodescomponents.parametersbut notcomponents.headers. The section was silently dropped at decode time, andOpenapiHeaderRef.resolvedonly ever consultedcomponents.parameters(additionally requiringin: header), so a response header written as$ref: '#/components/headers/Foo'passed ref validation and then failed at generation withIllegalStateException: Response component #/components/headers/Foo is referenced but not found.This adds
headerstoOpenapiComponent, re-keyed by full ref exactly asparametersalready is; makesOpenapiHeaderRef.resolvedconsultcomponents.headersfirst and fall back tocomponents.parametersunchanged; and adds the missingheaderscase toOpenApiMerger.Documents that do not use
components.headersare unaffected.Tests:
openapiCodegenCore2_12/test105 passing,openapiCodegenCore3/test115 passing,scalafmtCheckAllclean.🤖 Generated with Claude Code