-
Notifications
You must be signed in to change notification settings - Fork 63
fix(web): setLink consistency #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hejsztynx
wants to merge
7
commits into
main
Choose a base branch
from
@ksienkiewicz/fix-web-set-link-serialization-consistency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
936d00a
feat: e2e regression tests
hejsztynx 690dd3e
fix: consistent setLink comparison
hejsztynx a4cce4f
refactor: tweak e2e tests
hejsztynx 87a67fc
feat: setLink removes content when passed text is empty
hejsztynx ca2432d
feat: temporary test button
hejsztynx 9a7d7a8
Merge branch 'main' into @ksienkiewicz/fix-web-set-link-serialization…
hejsztynx 4307d55
docs: update docs
hejsztynx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -333,6 +333,21 @@ function App() { | |
| Push Text | ||
| </button> | ||
|
|
||
| <button | ||
| className="btn btn-full" | ||
| onClick={() => { | ||
| if (!selection) return; | ||
| ref.current?.setLink( | ||
| selection.start, | ||
| selection.end, | ||
| '', | ||
| 'swmansion.com' | ||
| ); | ||
| }} | ||
| > | ||
| setLink(text="") | ||
| </button> | ||
|
|
||
|
Comment on lines
+336
to
+350
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is for manual test purposes only. Will be removed on merge |
||
| {showHtmlOutput && <HtmlOutputPanel html={currentHtml} />} | ||
|
|
||
| <TextRenderer htmlValue={enrichedTextValue} /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.