Skip to content

fix(ios): conflicting styles in typing attributes not correctly detected #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejsztynx wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ios): conflicting styles in typing attributes not correctly detected #770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cea1910
fix: conflicting styles in typing attributes not correctly detected
hejsztynx Aug 13, 2026
671e0d7
refactor: comment tweak
hejsztynx Aug 13, 2026
251bc1e
Merge branch 'main' into @ksienkiewicz/fix-ios-inline-in-codeblock
hejsztynx Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ios/utils/StyleUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,19 +229,28 @@ + (NSArray *)getPresentStyleTypesFrom:(NSArray *)types
forHost:(id<EnrichedViewHost>)host {
NSMutableArray<NSNumber *> *resultArray =
[[NSMutableArray<NSNumber *> alloc] init];

// There might be a case where the given `range` doesn't have a conflicting
// style, but it is present in typing attributes. In that case, run `detect:`
// for good measure, since it considers typing attributes (unlike `any:`).
NSRange selectedRange = host.textView.selectedRange;
BOOL caretWithinRange = range.length >= 1 && selectedRange.length == 0 &&
selectedRange.location >= range.location &&
selectedRange.location <= NSMaxRange(range);

for (NSNumber *type in types) {
StyleBase *style = host.stylesDict[type];

if (range.length >= 1) {
if ([style any:range]) {
[resultArray addObject:type];
}
} else {
if ([style detect:range]) {
[resultArray addObject:type];
}
BOOL present = range.length >= 1 ? [style any:range] : [style detect:range];
if (!present && caretWithinRange) {
present = [style detect:selectedRange];
}

if (present) {
[resultArray addObject:type];
}
}

return resultArray;
}

Expand Down
Loading