-
Notifications
You must be signed in to change notification settings - Fork 51
fix(android): set piority of applied spans #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kacperzolkiewski
merged 5 commits into
main
from
@kacperzolkiewski/android-span-priority
Jun 19, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b985274
fix(android): set piority of applied spans
kacperzolkiewski 36f7c1d
fix: priority for images
kacperzolkiewski 592076e
Merge branch 'main' into @kacperzolkiewski/android-span-priority
kacperzolkiewski 70893d7
fix: apply priority for alignment spans
kacperzolkiewski 3c30563
fix: add comment to EnrichedSpanFlags
kacperzolkiewski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
android/src/main/java/com/swmansion/enriched/common/EnrichedSpanFlags.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package com.swmansion.enriched.common | ||
|
|
||
| import android.text.Spannable | ||
| import com.swmansion.enriched.common.spans.EnrichedAlignmentSpan | ||
| import com.swmansion.enriched.common.spans.interfaces.EnrichedInlineSpan | ||
|
|
||
| // Higher priority spans are processed first, so styles with lower priorities are painted on top of previously applied styles. | ||
| // For example, inline styles are applied on top of paragraph styles, allowing them to override paragraph-level styling. | ||
| // Alignment styles are applied last, ensuring they position the final, fully styled text. | ||
| object EnrichedSpanFlags { | ||
| private const val ALIGNMENT_SPAN_PRIORITY = 0 | ||
| private const val INLINE_SPAN_PRIORITY = 1 | ||
| private const val PARAGRAPH_SPAN_PRIORITY = 2 | ||
|
|
||
| @JvmStatic | ||
| @JvmOverloads | ||
| fun forSpan( | ||
| span: Any?, | ||
| baseFlags: Int = Spannable.SPAN_EXCLUSIVE_EXCLUSIVE, | ||
| ): Int { | ||
| val priority = | ||
| when (span) { | ||
| is EnrichedAlignmentSpan -> ALIGNMENT_SPAN_PRIORITY | ||
| is EnrichedInlineSpan -> INLINE_SPAN_PRIORITY | ||
| else -> PARAGRAPH_SPAN_PRIORITY | ||
| } | ||
| return applyPriority(baseFlags, priority) | ||
| } | ||
|
|
||
| private fun applyPriority( | ||
| flags: Int, | ||
| priority: Int, | ||
| ): Int { | ||
| // Cleaning up priority bits | ||
| val cleared = flags and Spannable.SPAN_PRIORITY.inv() | ||
| // Injecting priority bits | ||
| return cleared or ((priority shl Spannable.SPAN_PRIORITY_SHIFT) and Spannable.SPAN_PRIORITY) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.