-
-
Notifications
You must be signed in to change notification settings - Fork 49
feat: graph refactor chapter I #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
poneciak57
wants to merge
30
commits into
main
Choose a base branch
from
feat/graph_refactor_1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1f8331f
feat: prepared all files
poneciak57 96965f7
feat: audio graph impl
poneciak57 ee90045
feat: fat function impl with tests
poneciak57 2a15c07
fix: fixed tests
poneciak57 ec74d13
feat: declared api and implemented helpers for testing
poneciak57 bbba712
feat: implemented DSU
poneciak57 6f38afd
feat: implemented graph abstraction
poneciak57 266678d
chore: formatting
poneciak57 fef0455
chore: removed dsu impl
poneciak57 cdfa326
feat: changed host graph to use result
poneciak57 3ea1481
feat: implemented graph wrapper
poneciak57 5f7a529
feat: implemented ptr disposer
poneciak57 fa3a7da
feat: implemented proper memory management for audio graph
poneciak57 210c57a
fix: fixed issue with ghost nodes in hostgraph
poneciak57 381706b
feat: added templating to graphs
poneciak57 4bbd32c
feat: implemented solid separate standalone mock
poneciak57 18d45d6
feat: fixed audio thread allocation issue
poneciak57 485fffe
feat: added disposer back to events
poneciak57 5fdb386
feat: added separate script for running graph tests
poneciak57 d703f5d
fix: fixed tests issue
poneciak57 015d3ea
feat: updated CI to run graph tests only if graph related files have …
poneciak57 af5ad95
feat: added dockerfile for easier asan on macos
poneciak57 59c6fdf
fix: fixed issue with fat function move eq operator
poneciak57 649735e
Update .github/workflows/graph-tests.yml
poneciak57 a70a8f6
Update packages/react-native-audio-api/common/cpp/test/src/graph/Grap…
poneciak57 ec104b4
Update packages/react-native-audio-api/common/cpp/test/src/graph/Grap…
poneciak57 8167770
fix: fixed memory leak and comments from copilot
poneciak57 0e8b904
Merge branch 'feat/graph_refactor_1' of https://github.com/software-m…
poneciak57 88156eb
fix: fixed fat function to work properly with mutable closures
poneciak57 483b985
docs: graph overall docs with essential info
poneciak57 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Graph Tests | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/react-native-audio-api/common/cpp/audioapi/core/utils/graph/**' | ||
| - 'packages/react-native-audio-api/common/cpp/test/src/graph/**' | ||
|
|
||
| jobs: | ||
| graph-test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ./.github/actions/setup | ||
| - run: yarn test:graph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,4 @@ jobs: | |
|
|
||
| - name: Run tests | ||
| run: yarn test | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will be its future use case? because I assume this code will not stay like that at the end