Skip to content

fix(sort): preserve padded payloads and recognize buffer aliases - #3026

Draft
iwoplaza wants to merge 1 commit into
feat/radix-sort-v2from
fix/radix-sort-practical-fixes
Draft

iwoplaza wants to merge 1 commit into
feat/radix-sort-v2from
fix/radix-sort-practical-fixes

Conversation

@iwoplaza

Copy link
Copy Markdown
Collaborator

🤖 Authored by Codex, yet to be reviewed by me

Restore unsorted input before benchmark runs and keep one active demo sorter. Add GPU regression coverage for padding ties, repeated runs, and wrapped output buffers.

Restore unsorted input before benchmark runs and keep one active demo sorter. Add GPU regression coverage for padding ties, repeated runs, and wrapped output buffers.
@github-actions

Copy link
Copy Markdown

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@13e55b6ed99aa4a4a7eb80ffcaf3549e14143271
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/cli@13e55b6ed99aa4a4a7eb80ffcaf3549e14143271
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/gl@13e55b6ed99aa4a4a7eb80ffcaf3549e14143271

benchmark
view benchmark

commit
view commit

@github-actions

Copy link
Copy Markdown

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.62, 1.21, 2.65, 4.42, 4.69, 6.61, 15.43, 15.32]
  line [0.58, 1.12, 2.69, 4.54, 5.08, 6.85, 14.96, 15.34]
  line [0.68, 1.31, 2.69, 3.91, 4.71, 7.72, 14.30, 16.95]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.17, 0.32, 0.45, 0.55, 0.77, 0.80, 0.95, 0.99]
  line [0.21, 0.35, 0.43, 0.53, 0.71, 0.74, 0.87, 0.92]
  line [0.17, 0.39, 0.51, 0.59, 0.79, 0.81, 0.98, 1.07]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.61, 1.47, 2.52, 4.29, 7.88, 18.19, 36.13, 70.62]
  line [0.52, 1.40, 2.52, 4.31, 7.49, 16.64, 35.68, 72.34]
  line [0.55, 1.44, 2.18, 4.32, 7.68, 17.75, 35.53, 73.54]
Loading

@github-actions

Copy link
Copy Markdown

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased ➖ Unchanged 🔴 Increased ❔ Unknown
0 325 0 0

No notable changes.

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant