[WIP] feat (@typegpu/noise): LCG generator#2215
Open
cieplypolar wants to merge 141 commits intomainfrom
Open
Conversation
- need to store transition buffer, change only when counts change ;(
deluksic
reviewed
Mar 17, 2026
| * Naive Linear Congruential Generator (LCG) | ||
| */ | ||
| export const LCG: StatefulGenerator = (() => { | ||
| const seed = tgpu.privateVar(d.u32); |
Contributor
There was a problem hiding this comment.
I would argue this seed size is not going to be enough for any application with > 1M elements. The reason is simply that your whole internal random state is only ~4B so its going to have a lot of repetition, no matter how good the hashing function is.
Collaborator
Author
There was a problem hiding this comment.
You're right. This was part of earlier research. We ended up sticking with the current PRNG but figured that we'd include LCG in docs section about creating your own PRNG. Ultimately, LCG landed in noise package in this PR without much thinking about its performance 🙈. I'll update it to use larger seed and put xoroshiro64++ next to it 🫡
cieplypolar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
@typegpu/noise(hash,u32To01F32)uniformity)withPerformanceCallbackandwithTimestampWritesonguardedComputePipelineTODO:
u64Mul