Skip to content

[Playback] Explicit links in ReadState/WriteState - #6277

Open
alxbilger wants to merge 2 commits into
sofa-framework:masterfrom
alxbilger:readwritestate
Open

[Playback] Explicit links in ReadState/WriteState#6277
alxbilger wants to merge 2 commits into
sofa-framework:masterfrom
alxbilger:readwritestate

Conversation

@alxbilger

@alxbilger alxbilger commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Breaking because the name of a class data member changed.

[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: breaking Change possibly inducing a compilation error labels Aug 31, 2026
@alxbilger

alxbilger commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

fredroy
fredroy reviewed Aug 31, 2026
View reviewed changes

@fredroy fredroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to see why StateAccessor is needed and not SingleStateAccessor 😅

Comment thread Sofa/Component/Playback/src/sofa/component/playback/ReadState.h
Comment thread Sofa/Component/Playback/src/sofa/component/playback/ReadState.h
Comment thread Sofa/Component/Playback/src/sofa/component/playback/ReadState.inl
Comment thread Sofa/Component/Playback/src/sofa/component/playback/CompareState.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredroy fredroy fredroy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alxbilger @fredroy